Review main Merged

69034[TASK] Avoid GeneralUtility::_GET() in EXT:indexed_search

Oli Bartsch CR +2 V +2 Easy +21 −6 updated 05/05/21, 14:16

Commit message

The AdministrationController in EXT:indexed_search is based
on the extbase framework. As this provides a specific request
object, there is no need to use GeneralUtility::_GET() for
fetching plugin related arguments.

However, since the extbase specific request object does not
provide non-plugin related arguments (those without the plugin
prefix), we currently have to fetch them from the global PSR-7
request. This will vanish as soon as extbase does also use the
PSR-7 implementation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 05/05/21, 12:07

  2. Oli Bartsch uploaded patch set 2 05/05/21, 12:10

  3. core-ci voted on patch set 1 V +1 05/05/21, 12:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11204

  4. core-ci voted on patch set 2 V +1 05/05/21, 12:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11205

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 05/05/21, 14:10

  6. Benni Mack voted on patch set 2 V +2 CR +2 05/05/21, 14:16

  7. Benni Mack merged patch set 3 05/05/21, 14:16