Review main Merged

69035[TASK] Activate AppendedArrayItemTypeRule phpstan rule

Alexander Schnitzler CR +2 V +2 Normal +51 −27 updated 05/10/21, 09:41

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1316

  1. Alexander Schnitzler uploaded patch set 1 05/05/21, 12:40

  2. Alexander Schnitzler wrote 05/05/21, 12:40

    Topic set to phpstan
  3. core-ci voted on patch set 1 V -1 05/05/21, 12:51 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11206

  4. Alexander Schnitzler uploaded patch set 2 05/05/21, 12:51

  5. Alexander Schnitzler commented on patch set 2 05/05/21, 12:57

    CollectionInterface.php:26

  6. Alexander Schnitzler commented on patch set 2 05/05/21, 12:59

    This change is ready for review.
  7. core-ci voted on patch set 2 V +1 05/05/21, 13:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11208

  8. Daniel Goerz uploaded patch set 3 05/08/21, 10:49

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 05/08/21, 10:50

  10. core-ci voted on patch set 3 V +1 05/08/21, 11:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11314

  11. Oliver Klee voted on patch set 3 CR +1 05/08/21, 11:36

  12. Andreas Kienast commented on patch set 3 05/09/21, 10:58

    LinkService.php:58

    Do we need the if() at all? IIRC foreach() is a no-op on empty arrays.

    ResourceMutex.php:113

    Semi-related to that patch: I wonder whether `unset($this->workerLocks[$scope])` would be the better choice here.
  13. Alexander Schnitzler commented on patch set 3 05/09/21, 11:07

    LinkService.php:58 Reply Unresolved

    True, it's not needed. I kept the if conditon to not mix changes in function and code style because removing the diff results in removing indentation. But if you want to make this step, go for it. :)

    ResourceMutex.php:113 Reply Unresolved

    I personally like that approach because it shows absense of key and value. What we should do here in the long run is using a collection anyway and remove processed entries from the collection, hence, unsetting the key here, is closer to the result we are aiming for in the future I think.
  14. Jochen Roth voted on patch set 3 V +1 CR +1 05/10/21, 08:01

  15. Daniel Goerz commented on patch set 3 V +2 CR +2 05/10/21, 09:41

    Andi kindly allowed me to merge this as is 😊
  16. Daniel Goerz merged patch set 4 05/10/21, 09:41