Review main Merged

69036[TASK] Streamline EXT:belog filter

Christian Kuhn CR +2 V +2 Hard +75 −383 updated 05/05/21, 17:29

Commit message

To be more consistent with the backend user and redirects
module, the filter section of the backend log module is
streamlined.
The clumsy time range drop down is replaced, the 'user defined'
time selection via date pickers is always shown instead.
The hard to understand 'group by page' when called from
within info module having a depth > 0 is dropped, since a
similar information can be achieved more naturally using
the page tree selection.
The filter drop-downs don't reload automatically anymore
to be in-line with other modules, 'set' is renamed to
'Filter' and a 'Reset' button is added.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1014

  1. Christian Kuhn uploaded patch set 1 05/05/21, 12:46

  2. core-ci voted on patch set 1 V -1 05/05/21, 12:58 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11207

  3. Benni Mack uploaded patch set 2 05/05/21, 13:06

  4. Benni Mack uploaded patch set 3 05/05/21, 13:08

  5. Benni Mack uploaded patch set 4 05/05/21, 13:10

  6. core-ci voted on patch set 2 V +1 05/05/21, 13:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11209

  7. core-ci voted on patch set 3 V +1 05/05/21, 13:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11210

  8. core-ci voted on patch set 4 V +1 05/05/21, 13:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11211

  9. Guido Schmechel commented on patch set 4 05/05/21, 14:53

    Can we then optimise the behaviour for 0 hits directly? With the redirects module we get an info box displayed and with the users an empty table.
  10. Jochen Roth commented on patch set 4 05/05/21, 15:26

    Two things i noticed, the selected date format in datepicker is different to the format returned by the backend. The other thing is, when you on the input you get the datepicker as expected but when you close the datepicker by clicking somewhere else the input field gets emptied
  11. Christian Kuhn commented on patch set 4 05/05/21, 16:06

    Reply

    Yeah, the BE date pickers are a bit funny. We should have a deeper look at them. This is not touched by the patch, though - it just 'always' enables the existing pickers.
  12. Jochen Roth voted on patch set 4 V +1 CR +1 05/05/21, 16:15

  13. Anja Leichsenring voted on patch set 4 V +2 CR +2 05/05/21, 17:29

  14. Anja Leichsenring merged patch set 5 05/05/21, 17:29