69038[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- core-ci +1 CI
Issues 1
Files 24
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+4 −4
- typo3/sysext/install/Classes/ExtensionScanner/Php/CodeStatistics.php+2 −2
- typo3/sysext/install/Classes/FolderStructure/FileNode.php+8 −1
- typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php+3 −3
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+2 −2
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+5 −5
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+9 −6
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+2 −4
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/LinkHandler/AbstractLinkHandler.php+1 −1
- typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php+5 −5
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+2 −2
- typo3/sysext/scheduler/Classes/Command/SchedulerCommand.php+5 −1
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+2 −2
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerModuleFunctionController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+1 −1
Show 4 more files
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php1+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+1 −1
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Model/DatabaseRecord.php+1 −1
Review log 1317
-
Alexander Schnitzler uploaded patch set 1 05/05/21, 14:18
-
Alexander Schnitzler wrote 05/05/21, 14:19
Topic set to phpstan -
Alexander Schnitzler commented on patch set 1 05/05/21, 14:22
Adding you two as CC, just that you know I am working on this one. -
core-ci voted on patch set 1 V -1 05/05/21, 14:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11214
-
Daniel Goerz commented on patch set 1 05/11/21, 19:55
Over 200 errors to go, maybe we should split this one into smaller chunks to ease reviewing and reduce conflicts. -
Daniel Goerz uploaded patch set 2 05/12/21, 10:43
-
Daniel Goerz updated the commit message in patch set 3 05/12/21, 10:45
-
Alexander Schnitzler commented on patch set 3 05/12/21, 10:55
This change is ready for review. -
core-ci voted on patch set 2 V +1 05/12/21, 10:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11428
-
Daniel Goerz voted on patch set 3 V +1 CR +1 05/12/21, 10:59
-
Daniel Goerz updated the commit message in patch set 4 05/12/21, 11:00
-
Daniel Goerz voted on patch set 4 V +1 CR +1 05/12/21, 11:00
-
core-ci voted on patch set 3 V +1 05/12/21, 11:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11430
-
core-ci voted on patch set 4 V +1 05/12/21, 11:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11431
-
Benni Mack voted on patch set 4 V +2 CR +2 05/12/21, 12:03
-
Benni Mack merged patch set 5 05/12/21, 12:03
-
Daniel Goerz commented on patch set 5 05/12/21, 18:03
TypoScriptTemplateModuleController.php:221UnresolvedThis check needs to be adjusted, I'll include it in the next patch. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/69134