Review main Merged

69038[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule

Alexander Schnitzler CR +2 V +2 Normal +62 −51 updated 03/23/23, 18:50

Commit message

in

* EXT:workspaces
* EXT:tstemplate
* EXT:setup
* EXT:scheduler
* EXT:recycler
* EXT:lowlevel
* EXT:linkvalidator
* EXT:install
* EXT:info

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 1317

  1. Alexander Schnitzler uploaded patch set 1 05/05/21, 14:18

  2. Alexander Schnitzler wrote 05/05/21, 14:19

    Topic set to phpstan
  3. Alexander Schnitzler commented on patch set 1 05/05/21, 14:22

    Adding you two as CC, just that you know I am working on this one.
  4. core-ci voted on patch set 1 V -1 05/05/21, 14:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11214

  5. Daniel Goerz commented on patch set 1 05/11/21, 19:55

    Over 200 errors to go, maybe we should split this one into smaller chunks to ease reviewing and reduce conflicts.
  6. Daniel Goerz uploaded patch set 2 05/12/21, 10:43

  7. Daniel Goerz updated the commit message in patch set 3 05/12/21, 10:45

  8. Alexander Schnitzler commented on patch set 3 05/12/21, 10:55

    This change is ready for review.
  9. core-ci voted on patch set 2 V +1 05/12/21, 10:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11428

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 05/12/21, 10:59

  11. Daniel Goerz updated the commit message in patch set 4 05/12/21, 11:00

  12. Daniel Goerz voted on patch set 4 V +1 CR +1 05/12/21, 11:00

  13. core-ci voted on patch set 3 V +1 05/12/21, 11:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11430

  14. core-ci voted on patch set 4 V +1 05/12/21, 11:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11431

  15. Benni Mack voted on patch set 4 V +2 CR +2 05/12/21, 12:03

  16. Benni Mack merged patch set 5 05/12/21, 12:03

  17. Daniel Goerz commented on patch set 5 05/12/21, 18:03

    TypoScriptTemplateModuleController.php:221 Unresolved

    This check needs to be adjusted, I'll include it in the next patch. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/69134