Review 10.4 Merged

69052[BUGFIX] Log DataHandler errors instead of FlashMessage

Anja Leichsenring CR +2 V +2 Normal +33 −28 updated 05/11/21, 19:19

Commit message

DataHandler should log instead of creating FlashMessages
since FlashMessages fail in CLI context. Method
->printLogErrorMessages() turns DataHandler logs
into FlashMessages already and is used in appropriate
contexts like EditDocumentController and friends.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Anja Leichsenring uploaded patch set 1 05/05/21, 17:49

  2. core-ci voted on patch set 1 V -1 05/05/21, 17:51 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11228

  3. Christian Kuhn uploaded patch set 2 05/05/21, 17:59

  4. core-ci voted on patch set 2 V +1 05/05/21, 18:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11229

  5. Anja Leichsenring commented on patch set 2 05/05/21, 18:20

    I'd love a review here, this patch conflicted. One test also, we already saw a PHP language syntax error.
  6. Benni Mack voted on patch set 2 CR +1 05/06/21, 15:22

  7. Daniel Goerz voted on patch set 2 CR +1 05/11/21, 19:02

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 05/11/21, 19:19

  9. Anja Leichsenring merged patch set 3 05/11/21, 19:19