Review main Merged

69053[BUGFIX] Do not override disabled user settings

Alexander Stehlik CR +2 V +2 Easy +2 −2 updated 05/10/21, 12:42

Commit message

When the realName or email field of a user is disabled
by TSconfig, the current values will remain when saving.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Alexander Stehlik uploaded patch set 1 05/05/21, 18:28

  2. Alexander Stehlik commented on patch set 2 05/05/21, 18:29

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V +1 05/05/21, 18:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11230

  4. core-ci voted on patch set 2 V +1 05/05/21, 18:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11231

  5. Riccardo De Contardi commented on patch set 2 V +1 05/09/21, 20:24

    tested on latest master; tried with putting ``` setup.fields.realName.disabled = 1 setup.fields.email.disabled = 1 ``` on the TSConfig field of beuser and on begroup, too
  6. Richard Haeser updated the commit message in patch set 3 05/10/21, 08:16

  7. Richard Haeser voted on patch set 3 V +1 CR +1 05/10/21, 08:16

  8. core-ci voted on patch set 3 V +1 05/10/21, 08:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11330

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 05/10/21, 12:34

  10. Richard Haeser voted on patch set 3 V +2 CR +2 05/10/21, 12:42

  11. Richard Haeser merged patch set 4 05/10/21, 12:42