Review main Merged

69054[BUGFIX] Re-Allow Extbase Reflection for self

Benni Mack CR +2 V +2 Easy +30 −0 updated 05/06/21, 16:12

Commit message

Due to a bug in #94001 the Extbase Reflection of
"self" did not work anymore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • crell +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1015

  1. Benni Mack uploaded patch set 1 05/06/21, 07:43

  2. core-ci voted on patch set 1 V -1 05/06/21, 07:54 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11240

  3. Benni Mack uploaded patch set 2 05/06/21, 07:57

  4. core-ci voted on patch set 2 V -1 05/06/21, 08:08 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11241

  5. Benni Mack uploaded patch set 3 05/06/21, 10:27

  6. core-ci voted on patch set 3 V -1 05/06/21, 10:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11242

  7. Benni Mack uploaded patch set 4 05/06/21, 11:15

  8. core-ci voted on patch set 4 V +1 05/06/21, 11:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11245

  9. crell commented on patch set 4 05/06/21, 13:53

    Parameters cannot be typed as static, only as self. Return types can be either self or static. So the parameter part of the class doesn't need to check for static (syntax error). But if we care about return type, that needs to check for both self and static and have tests accordingly. Currently this patch only deals with parameters, so it's probably safe to just kill the static check, since it can never happen.
  10. Benni Mack uploaded patch set 5 05/06/21, 13:56

  11. core-ci voted on patch set 5 V +1 05/06/21, 14:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11258

  12. Oliver Hader voted on patch set 5 V +1 CR +1 05/06/21, 14:44

  13. crell voted on patch set 5 CR +1 05/06/21, 15:23

  14. Christian Kuhn voted on patch set 5 V +2 CR +2 05/06/21, 16:12

  15. Christian Kuhn merged patch set 6 05/06/21, 16:12