Review main Merged

69056[TASK] Streamline backend UriBuilder dependency injection

Benjamin Franzke CR +2 V +2 Normal +40 −14 updated 05/11/21, 18:20

Commit message

The Router dependency should not be optional and rather always be
injected, and in reality it always was, as the nullable fallback
to GeneralUtility::makeInstance was only used in unit tests.

The UriBuilder factory is now provided via the backend
service provider. That is because it became an ondemand
dependency for the backend request handler in #93674.
We now properly inject it via constructor which makes it
a lowlevel service (a service that needs to defined via
service provider to be available when TYPO3 has not yet
been installed).

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Benni Mack +2
    • Georg Ringer +1
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1216

  1. Benjamin Franzke uploaded patch set 1 05/06/21, 12:02

  2. core-ci voted on patch set 1 V -1 05/06/21, 12:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11248

  3. Benjamin Franzke uploaded patch set 2 05/06/21, 12:15

  4. core-ci voted on patch set 2 V -1 05/06/21, 12:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11249

  5. Benjamin Franzke uploaded patch set 3 05/06/21, 13:16

  6. core-ci voted on patch set 3 V +1 05/06/21, 13:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11255

  7. Benjamin Franzke updated the commit message in patch set 4 05/06/21, 18:37

  8. core-ci voted on patch set 4 V +1 05/06/21, 18:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11270

  9. Benjamin Franzke wrote 05/07/21, 20:56

    Topic set to di
  10. Benni Mack voted on patch set 4 CR +1 05/08/21, 11:26

  11. Andreas Kienast voted on patch set 4 CR +1 05/09/21, 11:05

  12. Georg Ringer voted on patch set 4 V +1 CR +1 05/09/21, 17:36

  13. Richard Haeser voted on patch set 4 CR +1 05/10/21, 08:20

  14. Daniel Goerz voted on patch set 4 V +2 CR +2 05/11/21, 18:18

  15. Benni Mack voted on patch set 4 V +2 CR +2 05/11/21, 18:20

  16. Daniel Goerz merged patch set 5 05/11/21, 18:20