69056[TASK] Streamline backend UriBuilder dependency injection
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Benni Mack +2
- Georg Ringer +1
- Richard Haeser +1
- Andreas Kienast +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Http/RequestHandler.php+9 −8
- typo3/sysext/backend/Classes/Routing/UriBuilder.php+3 −3
- typo3/sysext/backend/Classes/ServiceProvider.php+13 −1
- typo3/sysext/backend/Tests/Unit/View/ArrayBrowserTest.php+5 −0
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+2 −0
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/LinkViewHelperTest.php+3 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/UriViewHelperTest.php+3 −1
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+2 −0
Review log 1216
-
Benjamin Franzke uploaded patch set 1 05/06/21, 12:02
-
core-ci voted on patch set 1 V -1 05/06/21, 12:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11248
-
Benjamin Franzke uploaded patch set 2 05/06/21, 12:15
-
core-ci voted on patch set 2 V -1 05/06/21, 12:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11249
-
Benjamin Franzke uploaded patch set 3 05/06/21, 13:16
-
core-ci voted on patch set 3 V +1 05/06/21, 13:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11255
-
Benjamin Franzke updated the commit message in patch set 4 05/06/21, 18:37
-
core-ci voted on patch set 4 V +1 05/06/21, 18:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11270
-
Benjamin Franzke wrote 05/07/21, 20:56
Topic set to di -
Benni Mack voted on patch set 4 CR +1 05/08/21, 11:26
-
Andreas Kienast voted on patch set 4 CR +1 05/09/21, 11:05
-
Georg Ringer voted on patch set 4 V +1 CR +1 05/09/21, 17:36
-
Richard Haeser voted on patch set 4 CR +1 05/10/21, 08:20
-
Daniel Goerz voted on patch set 4 V +2 CR +2 05/11/21, 18:18
-
Benni Mack voted on patch set 4 V +2 CR +2 05/11/21, 18:20
-
Daniel Goerz merged patch set 5 05/11/21, 18:20