Review main Merged

69059[TASK] Remove unused key "name" in TBE_STYLES

Nikita Hovratov CR +2 V +2 Easy +1 −6 updated 05/10/21, 13:56

Commit message

There is no usage of the key "name" in
$GLOBALS['TBE_STYLES']['skins']['backend'].

Even in earlier versions of TYPO3 no usage can be found in the code.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Nikita Hovratov uploaded patch set 1 05/06/21, 21:06

  2. core-ci voted on patch set 1 V +1 05/06/21, 21:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11273

  3. Benjamin Franzke voted on patch set 1 V +1 CR +1 05/07/21, 20:52

  4. Oli Bartsch commented on patch set 1 V +1 CR +1 05/10/21, 12:41

    It's implicit displayed in the configuration module. Therefore, extension authors could use it to add additional information about the styles. However, in this case, it's the same as the key, so I'm fine with removing it.
  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 05/10/21, 13:55

  6. Benjamin Franzke merged patch set 2 05/10/21, 13:56