69062[TASK] Reduce ObjectManager usages within ConfigurationManager
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/core/Configuration/Services.yaml1+4 −0
- typo3/sysext/extbase/Classes/Configuration/AbstractConfigurationManager.php+6 −22
- typo3/sysext/extbase/Classes/Configuration/ConfigurationManager.php3+9 −15
- typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php+2 −13
- typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php+13 −13
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php+2 −5
- typo3/sysext/extbase/Classes/ServiceProvider.php2+1 −4
- typo3/sysext/extbase/Configuration/Services.yaml+7 −1
- typo3/sysext/extbase/Tests/Functional/Service/ExtensionServiceTest.php+12 −12
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+42 −12
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+5 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Typo3QuerySettingsTest.php+6 −1
- typo3/sysext/fluid/Classes/View/StandaloneView.php+6 −11
- typo3/sysext/fluid/Classes/View/TemplatePaths.php+3 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+1 −3
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+3 −6
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/CObjectViewHelperTest.php+11 −7
Review log 1927
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 05/07/21, 09:00
-
core-ci voted on patch set 1 V -1 05/07/21, 09:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11280
-
Benni Mack uploaded patch set 2 05/07/21, 11:01
-
core-ci voted on patch set 2 V -1 05/07/21, 11:16 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11284
-
Benjamin Franzke commented on patch set 2 05/07/21, 12:55
-
Benjamin Franzke uploaded patch set 3 05/07/21, 13:20
-
Benjamin Franzke commented on patch set 3 05/07/21, 13:20
ConfigurationManager.php:50ReplyDone -
Benni Mack uploaded patch set 4 05/07/21, 14:11
-
core-ci voted on patch set 4 V -1 05/07/21, 14:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11290
-
Benni Mack uploaded patch set 5 05/07/21, 14:59
-
Benni Mack uploaded patch set 6 05/07/21, 15:06
-
core-ci voted on patch set 5 V -1 05/07/21, 15:17 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11294
-
core-ci voted on patch set 6 V -1 05/07/21, 15:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11296
-
Benjamin Franzke uploaded patch set 7 05/07/21, 19:10
-
core-ci voted on patch set 7 V -1 05/07/21, 19:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11298
-
Benni Mack uploaded patch set 8 05/07/21, 19:44
-
Benjamin Franzke commented on patch set 8 CR -1 05/07/21, 19:54
ServiceProvider.php:46on it… this currently means we get two instances if both Configuration\ConfigurationManager and Configuration\ConfigurationManagerInterface are requests. Will have a look, possible soltuon is a separate factory for the interface that uses $container->get(Configuration\ConfigurationManager::class) in order to assure there is really ony one instance created. -
core-ci voted on patch set 8 V +1 05/07/21, 19:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11300
-
Benjamin Franzke uploaded patch set 9 05/07/21, 20:12
-
Benjamin Franzke commented on patch set 9 05/07/21, 20:13
ServiceProvider.php:46ReplyResolves by rather using ConfigurationManager in order not to confuse symfony di by defining an interface as a service. (haven't tested that thoroughly yet, therefore i think this is the safest way). -
core-ci voted on patch set 9 V +1 05/07/21, 20:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11302
-
Benjamin Franzke voted on patch set 9 CR +1 05/07/21, 20:25
-
Benni Mack commented on patch set 9 CR +1 05/07/21, 20:39
thanks for adaptions. -
Benjamin Franzke voted on patch set 9 V +1 05/07/21, 20:39
-
Daniel Goerz voted on patch set 9 V +2 CR +2 05/08/21, 10:04
-
Daniel Goerz merged patch set 10 05/08/21, 10:04
-
Christian Kuhn commented on patch set 10 06/10/21, 11:03
Services.yaml:119UnresolvedCorrect namespace is TYPO3\CMS\Core\TypoScript\TypoScriptService https://review.typo3.org/c/Packages/TYPO3.CMS/+/69426ConfigurationManager.php:38UnresolvedTYPO3\CMS\Form\Mvc\Configuration\ConfigurationManager still used this ... Will fix.
ConfigurationManager.php:50