Review main Merged

69062[TASK] Reduce ObjectManager usages within ConfigurationManager

Benni Mack CR +2 V +2 Hard +133 −131 updated 06/12/21, 18:41

Commit message

This change removes any objectManager usages within Configuration
Manager.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 1927

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 05/07/21, 09:00

  2. core-ci voted on patch set 1 V -1 05/07/21, 09:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11280

  1. Benni Mack uploaded patch set 2 05/07/21, 11:01

  2. core-ci voted on patch set 2 V -1 05/07/21, 11:16 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11284

  3. Benjamin Franzke commented on patch set 2 05/07/21, 12:55

    ConfigurationManager.php:50

    Let's inject ContainerInterface for lazy loading services and rather avoid GeneralUtility::makeInstance(). Or do you want to do that in the later ConfigurationManagerFactory?
  4. Benjamin Franzke uploaded patch set 3 05/07/21, 13:20

  5. Benjamin Franzke commented on patch set 3 05/07/21, 13:20

    ConfigurationManager.php:50 Reply

    Done
  6. Benni Mack uploaded patch set 4 05/07/21, 14:11

  7. core-ci voted on patch set 4 V -1 05/07/21, 14:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11290

  8. Benni Mack uploaded patch set 5 05/07/21, 14:59

  9. Benni Mack uploaded patch set 6 05/07/21, 15:06

  10. core-ci voted on patch set 5 V -1 05/07/21, 15:17 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11294

  11. core-ci voted on patch set 6 V -1 05/07/21, 15:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11296

  12. Benjamin Franzke uploaded patch set 7 05/07/21, 19:10

  13. core-ci voted on patch set 7 V -1 05/07/21, 19:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11298

  14. Benni Mack uploaded patch set 8 05/07/21, 19:44

  15. Benjamin Franzke commented on patch set 8 CR -1 05/07/21, 19:54

    ServiceProvider.php:46

    on it… this currently means we get two instances if both Configuration\ConfigurationManager and Configuration\ConfigurationManagerInterface are requests. Will have a look, possible soltuon is a separate factory for the interface that uses $container->get(Configuration\ConfigurationManager::class) in order to assure there is really ony one instance created.
  16. core-ci voted on patch set 8 V +1 05/07/21, 19:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11300

  17. Benjamin Franzke uploaded patch set 9 05/07/21, 20:12

  18. Benjamin Franzke commented on patch set 9 05/07/21, 20:13

    ServiceProvider.php:46 Reply

    Resolves by rather using ConfigurationManager in order not to confuse symfony di by defining an interface as a service. (haven't tested that thoroughly yet, therefore i think this is the safest way).
  19. core-ci voted on patch set 9 V +1 05/07/21, 20:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11302

  20. Benjamin Franzke voted on patch set 9 CR +1 05/07/21, 20:25

  21. Benni Mack commented on patch set 9 CR +1 05/07/21, 20:39

    thanks for adaptions.
  22. Benjamin Franzke voted on patch set 9 V +1 05/07/21, 20:39

  23. Daniel Goerz voted on patch set 9 V +2 CR +2 05/08/21, 10:04

  24. Daniel Goerz merged patch set 10 05/08/21, 10:04

  25. Christian Kuhn commented on patch set 10 06/10/21, 11:03

    Services.yaml:119 Unresolved

    Correct namespace is TYPO3\CMS\Core\TypoScript\TypoScriptService https://review.typo3.org/c/Packages/TYPO3.CMS/+/69426

    ConfigurationManager.php:38 Unresolved

    TYPO3\CMS\Form\Mvc\Configuration\ConfigurationManager still used this ... Will fix.