Review main Merged

69064[BUGFIX] Fix InputLinkElement to be visible again

Nikita Hovratov CR +2 V +2 Easy +28 −18 updated 05/11/21, 21:01

Commit message

Since the bootstrap v5 update, the inputLinkElement is styled with flex
form instead of display table. This became a problem, because this broke
the appearance of the explanation toggling.

The initial idea to hide the complete clearable wrap didn't work
properly as it is loaded dynamically and it's not ensured it exists
when trying to hide it.

To circumvent this problem, the styling is now done with some extra css.
Additionally the wrong form-control class is removed from the clearable
wrap and the styling is now also moved to own css.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 68

  1. Nikita Hovratov uploaded patch set 1 05/07/21, 12:03

  2. core-ci voted on patch set 1 V +1 05/07/21, 12:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11285

  3. Oli Bartsch uploaded patch set 2 05/10/21, 19:10

  4. core-ci voted on patch set 2 V +1 05/10/21, 19:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11359

  5. Benni Mack voted on patch set 2 V +1 CR +1 05/11/21, 20:39

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 05/11/21, 20:57

  7. Benni Mack voted on patch set 2 V +2 CR +2 05/11/21, 21:01

  8. Benni Mack merged patch set 3 05/11/21, 21:01