Review main Merged

69066[BUGFIX] Only return translation count message for a non-zero count

Andreas Kienast CR +2 V +2 Easy +4 −8 updated 05/11/21, 19:17

Commit message

With #93979, `BackendUtility::translationCount()` was changed and always
returned the message "This record has X translation(s) [...]!" even if
there are no translated records at all.

This patch initializes `$count` as 0 and changes the message handling as
similar as in `BackendUtility::referenceCount()`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Daniel Goerz +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Daniel Goerz +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1620

  1. Andreas Kienast uploaded patch set 1 05/07/21, 13:29

  2. Andreas Kienast rebased onto patch set 2 05/07/21, 14:54

  3. Martin Kutschker updated the commit message in patch set 3 05/07/21, 14:59

  4. Martin Kutschker voted on patch set 3 CR +1 05/07/21, 15:00

  5. core-ci voted on patch set 2 V +1 05/07/21, 15:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11293

  6. core-ci voted on patch set 3 V +1 05/07/21, 15:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11295

  7. Benjamin Franzke voted on patch set 3 V +1 CR +1 05/07/21, 19:50

  8. Anja Leichsenring updated the commit message in patch set 4 05/11/21, 18:31

  9. Oli Bartsch voted on patch set 4 V +1 CR +1 05/11/21, 18:35

  10. Daniel Goerz voted on patch set 4 V +2 CR +2 05/11/21, 18:36

  11. core-ci voted on patch set 4 V +1 05/11/21, 18:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11389

  12. Oli Bartsch voted on patch set 4 V +2 CR +2 05/11/21, 18:47

  13. Daniel Goerz voted on patch set 4 V 0 CR 0 05/11/21, 18:51

  14. Daniel Goerz updated the commit message in patch set 5 05/11/21, 18:51

  15. Oli Bartsch voted on patch set 4 V 0 CR 0 05/11/21, 18:51

  16. Daniel Goerz voted on patch set 5 V +1 CR +1 05/11/21, 18:55

  17. core-ci voted on patch set 5 V +1 05/11/21, 19:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11393

  18. Benjamin Franzke voted on patch set 5 V +1 CR +1 05/11/21, 19:17

  19. Oli Bartsch voted on patch set 5 V +2 CR +2 05/11/21, 19:17

  20. Oli Bartsch merged patch set 6 05/11/21, 19:17