Review main Merged

69098[BUGFIX] Fix range handling for eval double

Patrick Schriner CR +2 V +2 Normal +79 −3 updated 06/15/21, 17:55

Commit message

If a field has a '''double''' eval, '''upper''' and '''lower''' range
checks don't work as expected as the value is always cast to an int
before comparison.

Switching to floor and ceil helps with these edge cases while retaining
the casting to int behaviour.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Patrick Schriner uploaded patch set 1 05/10/21, 12:41

  2. core-ci voted on patch set 1 V +1 05/10/21, 12:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11340

  3. Christian Kuhn commented on patch set 1 05/11/21, 12:39

    Nice edge case. I hope it's ok to drop 9.5 from merge-list, it's not a critical fix. Will give it an in-depth review soon.
  4. Christian Kuhn updated the commit message in patch set 2 05/11/21, 12:39

  5. core-ci voted on patch set 2 V +1 05/11/21, 12:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11377

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 05/12/21, 13:16

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 06/15/21, 17:54

  8. Anja Leichsenring merged patch set 3 06/15/21, 17:55