Review main Merged

69101[TASK] Remove objectManager from various Extbase places

Benni Mack CR +2 V +2 Hard +83 −181 updated 05/12/21, 13:14

Commit message

This change adapts certain areas within EXT:extbase
Persistence to avoid ObjectManager and rely on constructor
DI and GeneralUtility::makeInstance() where it's not
easily possible to switch to DI yet.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 68

  1. Benni Mack uploaded patch set 1 05/10/21, 20:44

  2. core-ci voted on patch set 1 V +1 05/10/21, 20:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11365

  3. Benni Mack updated the commit message in patch set 2 05/11/21, 15:26

  4. core-ci voted on patch set 2 V +1 05/11/21, 15:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11380

  5. Daniel Goerz voted on patch set 2 CR +1 05/11/21, 17:25

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 05/12/21, 12:58

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 05/12/21, 13:14

  8. Daniel Goerz merged patch set 3 05/12/21, 13:14