Review main Merged

69108[TASK] Implement ValuePicker as custom web component

Andreas Kienast CR +2 V +2 Normal +126 −52 updated 05/13/21, 10:14

Commit message

TCA's value picker uses a lot inline JavaScript for its
picker handling, therefore, the handling has been moved
into a dedicated web component.

As a side-effect a bug in TextElement and InputTextElement
is fixed. Both elements previously used exactly the opposite
insert mode.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2028

Show 23 earlier messages
  1. Andreas Kienast uploaded patch set 1 05/11/21, 15:43

  2. core-ci voted on patch set 1 V +1 05/11/21, 15:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11383

  3. Oli Bartsch uploaded patch set 2 05/11/21, 20:30

  1. core-ci voted on patch set 2 V +1 05/11/21, 20:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11410

  2. Oli Bartsch voted on patch set 2 V +1 CR +1 05/11/21, 20:57

  3. Benjamin Franzke commented on patch set 2 05/11/21, 21:19

    TextElement.php:209

    Hm, so we introduce a new module because too many inline javascript was used and now this is still using inline javascript for the initialization. Would be great to write a wrapper webcomponent as outlined in the following WIP patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68107/7/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/ColorPicker.ts
  4. Oli Bartsch uploaded patch set 3 05/12/21, 10:43

  5. Oli Bartsch updated the commit message in patch set 4 05/12/21, 10:44

  6. core-ci voted on patch set 3 V +1 05/12/21, 11:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11427

  7. Andreas Kienast commented on patch set 4 CR -2 05/12/21, 11:01

    TextElement.php:209 Reply

    Do I get it right your idea is to extract the ValuePicker as a separate web component? Sounds reasonable (and re-usable!), can take care of it.
  8. Andreas Kienast commented on patch set 4 CR 0 05/12/21, 11:04

    TextElement.php:209 Reply

    Ah, I didn't notice this patch was rebuilt already.
  9. core-ci voted on patch set 4 V +1 05/12/21, 11:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11429

  10. Benjamin Franzke commented on patch set 4 05/12/21, 11:14

    InputLinkElement.php:194

    Thanks oli for the adaptions! Just a small nitpick, would be even cooler if we move the properties data-mode and data-linked-field to the component attributes: <typo3-formengine-valuepicker mode="…" linked-field="…"> And then use `this.getAttribute('mode')` or `this.getAttribute('linked-field')` instead of this.controlElement.dataset.linkedField in the component class. I can also work on that if you like later on, but unfortunately there's no time for me today…
  11. Oli Bartsch commented on patch set 4 05/12/21, 11:18

    InputLinkElement.php:194 Reply

    Will take care, thanks for the feedback.
  12. Oli Bartsch uploaded patch set 5 05/12/21, 11:35

  13. Oli Bartsch commented on patch set 5 05/12/21, 11:38

    InputLinkElement.php:194 Reply

    Done

    TextElement.php:209 Reply

    Done
  14. core-ci voted on patch set 5 V +1 05/12/21, 11:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11432

  15. Andreas Kienast uploaded patch set 6 05/13/21, 09:36

  16. Andreas Kienast voted on patch set 6 V +1 CR +1 05/13/21, 09:37

  17. Andreas Kienast commented on patch set 6 05/13/21, 09:37

    I've only renamend the mode "insert" to "replace" as it's more descriptive.
  18. core-ci voted on patch set 6 V +1 05/13/21, 09:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11472

  19. Benjamin Franzke commented on patch set 6 CR -1 05/13/21, 09:56

    No major remarks, just preparing a little refactoring…
  20. Benjamin Franzke uploaded patch set 7 05/13/21, 10:00

  21. Benjamin Franzke uploaded patch set 8 05/13/21, 10:03

  22. core-ci voted on patch set 7 V -1 05/13/21, 10:10 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11473

  23. core-ci voted on patch set 8 V +1 05/13/21, 10:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11474

  24. Andreas Kienast voted on patch set 8 V +2 CR +2 05/13/21, 10:14

  25. Andreas Kienast merged patch set 9 05/13/21, 10:14