69108[TASK] Implement ValuePicker as custom web component
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/FieldWizard/ValuePicker.tsnew+70 −0
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php3+14 −17
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+14 −17
- typo3/sysext/backend/Classes/Form/Element/TextElement.php4+14 −17
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/FieldWizard/ValuePicker.jsnew+13 −0
Review log 2028
Show 23 earlier messages
-
Andreas Kienast uploaded patch set 1 05/11/21, 15:43
-
core-ci voted on patch set 1 V +1 05/11/21, 15:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11383
-
Oli Bartsch uploaded patch set 2 05/11/21, 20:30
-
core-ci voted on patch set 2 V +1 05/11/21, 20:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11410
-
Oli Bartsch voted on patch set 2 V +1 CR +1 05/11/21, 20:57
-
Benjamin Franzke commented on patch set 2 05/11/21, 21:19
-
Oli Bartsch uploaded patch set 3 05/12/21, 10:43
-
Oli Bartsch updated the commit message in patch set 4 05/12/21, 10:44
-
core-ci voted on patch set 3 V +1 05/12/21, 11:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11427
-
Andreas Kienast commented on patch set 4 CR -2 05/12/21, 11:01
TextElement.php:209ReplyDo I get it right your idea is to extract the ValuePicker as a separate web component? Sounds reasonable (and re-usable!), can take care of it. -
Andreas Kienast commented on patch set 4 CR 0 05/12/21, 11:04
TextElement.php:209ReplyAh, I didn't notice this patch was rebuilt already. -
core-ci voted on patch set 4 V +1 05/12/21, 11:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11429
-
Benjamin Franzke commented on patch set 4 05/12/21, 11:14
InputLinkElement.php:194Thanks oli for the adaptions! Just a small nitpick, would be even cooler if we move the properties data-mode and data-linked-field to the component attributes: <typo3-formengine-valuepicker mode="…" linked-field="…"> And then use `this.getAttribute('mode')` or `this.getAttribute('linked-field')` instead of this.controlElement.dataset.linkedField in the component class. I can also work on that if you like later on, but unfortunately there's no time for me today… -
Oli Bartsch commented on patch set 4 05/12/21, 11:18
InputLinkElement.php:194ReplyWill take care, thanks for the feedback. -
Oli Bartsch uploaded patch set 5 05/12/21, 11:35
-
Oli Bartsch commented on patch set 5 05/12/21, 11:38
InputLinkElement.php:194ReplyDoneTextElement.php:209ReplyDone -
core-ci voted on patch set 5 V +1 05/12/21, 11:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11432
-
Andreas Kienast uploaded patch set 6 05/13/21, 09:36
-
Andreas Kienast voted on patch set 6 V +1 CR +1 05/13/21, 09:37
-
Andreas Kienast commented on patch set 6 05/13/21, 09:37
I've only renamend the mode "insert" to "replace" as it's more descriptive. -
core-ci voted on patch set 6 V +1 05/13/21, 09:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11472
-
Benjamin Franzke commented on patch set 6 CR -1 05/13/21, 09:56
No major remarks, just preparing a little refactoring… -
Benjamin Franzke uploaded patch set 7 05/13/21, 10:00
-
Benjamin Franzke uploaded patch set 8 05/13/21, 10:03
-
core-ci voted on patch set 7 V -1 05/13/21, 10:10 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11473
-
core-ci voted on patch set 8 V +1 05/13/21, 10:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11474
-
Andreas Kienast voted on patch set 8 V +2 CR +2 05/13/21, 10:14
-
Andreas Kienast merged patch set 9 05/13/21, 10:14
TextElement.php:209