Review main Merged

69132[BUGFIX] Ensure UriBuilder always contains a cObj

Benni Mack CR +2 V +2 Easy +8 −4 updated 05/12/21, 16:43

Commit message

When UriBuilder is used outside of an initialized ExtbaseAction
and not within StandaloneView, the cObj is not properly initialized
inside Extbase's UriBuilder

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Benni Mack uploaded patch set 1 05/12/21, 14:21

  2. core-ci voted on patch set 1 V +1 05/12/21, 14:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11443

  3. Benni Mack commented on patch set 2 05/12/21, 15:30

    Published edit on patch set 1.
  4. Oli Bartsch uploaded patch set 3 05/12/21, 15:35

  5. Oli Bartsch voted on patch set 3 V +1 CR +1 05/12/21, 15:37

  6. core-ci voted on patch set 2 V +1 05/12/21, 15:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11446

  7. core-ci voted on patch set 3 V +1 05/12/21, 15:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11447

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 05/12/21, 16:43

  9. Christian Kuhn merged patch set 4 05/12/21, 16:43