Review 10.4 Merged

69133[BUGFIX] Ensure UriBuilder always contains a cObj

Christian Kuhn CR +2 V +2 Easy +4 −1 updated 09/17/21, 13:12

Commit message

When UriBuilder is used outside of an initialized ExtbaseAction
and not within StandaloneView, the cObj is not properly initialized
inside Extbase's UriBuilder

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 58

  1. Christian Kuhn uploaded patch set 1 05/12/21, 16:52

  2. core-ci voted on patch set 1 V -1 05/12/21, 17:05 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11450

  3. Christian Kuhn uploaded patch set 2 05/12/21, 17:09

  4. core-ci voted on patch set 2 V -1 05/12/21, 17:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11451

  5. core-ci voted on patch set 2 V +1 05/12/21, 18:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11454

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 05/12/21, 18:06

  7. Christian Kuhn merged patch set 3 05/12/21, 18:06

  8. Benni Mack wrote 09/17/21, 13:12

    Created a revert of this change as I2a1cdd4e9a5f0f7dc938397d38d28713340b048b