Review main Merged

69134[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule

Daniel Goerz CR +2 V +2 Normal +55 −57 updated 05/19/21, 09:25

Commit message

* EXT: backend
* EXT: belog
* EXT: beuser

In addition an adjustment is added that was forgotten in
https://review.typo3.org/c/Packages/TYPO3.CMS/+/69038

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 1317

  1. Daniel Goerz uploaded patch set 1 05/12/21, 17:56

  2. Daniel Goerz uploaded patch set 2 05/12/21, 18:03

  3. Daniel Goerz commented on patch set 2 05/12/21, 18:04

    TypoScriptTemplateModuleController.php:221 Unresolved

  4. Daniel Goerz wrote 05/12/21, 18:04

    Topic set to phpstan
  5. core-ci voted on patch set 1 V +1 05/12/21, 18:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11455

  6. core-ci voted on patch set 2 V +1 05/12/21, 18:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11456

  7. Oli Bartsch voted on patch set 2 CR +1 05/12/21, 18:56

  8. Daniel Goerz uploaded patch set 3 05/19/21, 07:27

  9. core-ci voted on patch set 3 V +1 05/19/21, 07:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11660

  10. Jochen Roth voted on patch set 3 V +1 CR +1 05/19/21, 08:28

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 05/19/21, 08:44

  12. Daniel Goerz uploaded patch set 4 05/19/21, 08:51

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 05/19/21, 08:56

  14. core-ci voted on patch set 4 V +1 05/19/21, 09:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11665

  15. Jochen Roth voted on patch set 4 V +1 CR +1 05/19/21, 09:11

  16. Daniel Goerz voted on patch set 4 V +2 CR +2 05/19/21, 09:25

  17. Daniel Goerz merged patch set 5 05/19/21, 09:25