Review main Merged

69135[BUGFIX] Ensure throwStatus in Extbase stops the execution workflow

Benni Mack CR +2 V +2 Easy +7 −8 updated 05/18/21, 09:40

Commit message

Extbase's throwStatus() method is mentioned that
the execution workflow indeed should be stopped
right away, but never did, as all of TSFE's code
was executed again and again.

Since TYPO3 v11 (#93007) we now have a "PropagateResponseException"
and native PSR-7 Responses in Extbase, which allows us
to do exactly that: Stop and have the Application emit
the response directly with the status code.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Benni Mack uploaded patch set 1 05/12/21, 19:36

  2. core-ci voted on patch set 1 V +1 05/12/21, 19:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11458

  3. Benni Mack uploaded patch set 2 05/12/21, 20:51

  4. core-ci commented on patch set 2 05/12/21, 21:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11460

  5. Benni Mack commented on patch set 3 05/14/21, 09:23

    Published edit on patch set 2.
  6. Susi Moog voted on patch set 3 CR +1 05/14/21, 09:24

  7. core-ci voted on patch set 3 V +1 05/14/21, 09:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11492

  8. Andreas Kienast voted on patch set 3 CR +1 05/14/21, 11:27

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 05/14/21, 14:22

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 05/17/21, 14:25

  11. Benni Mack voted on patch set 3 V +2 CR +2 05/18/21, 09:40

  12. Benni Mack merged patch set 4 05/18/21, 09:40