Review main Merged

69136[TASK] Ensure all Extbase plugins can be cacheable and non-cacheable

Benni Mack CR +2 V +2 Normal +46 −70 updated 05/27/21, 16:19

Commit message

This change moves the detection of USER/USER_INT from
the FrontendRequestHandler to Extbase Bootstrap->run(),
allowing custom extbase request handlers to now be
converted to USER_INT to run uncached.

This further separates the TSFE/cObj logic from Extbase
into the main entrypoint (Bootstrap), making Extbase less
aware of cObjects and their internal cacheable logic.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Benni Mack uploaded patch set 1 05/12/21, 20:51

  2. core-ci voted on patch set 1 V +1 05/12/21, 21:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11461

  3. Andreas Kienast voted on patch set 1 CR +1 05/13/21, 10:35

  4. Susi Moog voted on patch set 1 CR +1 05/14/21, 05:02

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 05/17/21, 14:38

  6. Benjamin Franzke commented on patch set 1 05/17/21, 22:09

    Bootstrap.php:160

    Why changed to `?string`? handleRequest always returns string, so that's not necessary right now. Did you intend to return null instead of '' during user-to-userint conversion in handleRequest?

    Bootstrap.php:167

    When moving USER/USER_INT code in here, we should probably rename it to handleFrontendRequest or even better `handleContentObjectRequest` to make it crystal clear, that this method is only used (and not just "may be used") in frontend content-object/plugin context – and that USER-to-USERINT conversion is therefore "fine" to be done here. What do you think?
  7. Benjamin Franzke commented on patch set 1 05/17/21, 22:15

    Maybe add ", allowing custom extbase request handlers to now be converted to USER_INT to run uncached". That would be an explanation for the headline "Ensure all Extbase plugins can be cacheable and non-cacheable", or did you mean something different with that headline?
  8. Benni Mack uploaded patch set 2 05/18/21, 21:26

  9. Benni Mack commented on patch set 2 05/18/21, 21:27

    Reply

    Ack

    Bootstrap.php:160 Reply

    thanks. wrong change by me.

    Bootstrap.php:167 Reply

    yes. I also thought of bringing both methods together but I do like the "handleFrontendRequest" for the time being, let's see how we can split up ConfigurationManager logic (and the TypoScript configuration) later-on. I have a couple of more bugfixes planned in this area which are listed in forge.
  10. core-ci voted on patch set 2 V +1 05/18/21, 21:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11647

  11. Benni Mack uploaded patch set 3 05/18/21, 21:38

  12. core-ci commented on patch set 3 05/18/21, 21:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11651

  13. Jochen Roth voted on patch set 3 V +1 CR +1 05/27/21, 13:02

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 05/27/21, 16:19

  15. Christian Kuhn merged patch set 4 05/27/21, 16:19