Review main Merged

69137[BUGFIX] Fix Drag+Drop in Page Module in Workspaces

Benni Mack CR +2 V +2 Easy +21 −27 updated 05/17/21, 14:39

Commit message

When using Drag+Drop in Page Module a different
functionality is used than using Clipboard (Move+Paste)
while moving a record in the page module.

This results in a different behaviour when dealing in Workspaces.

The patch uses the same "cmd" instead of "data"
for DataHandler now for Drag+Drop than in Clipboard.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Richard Haeser +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Benni Mack uploaded patch set 1 05/12/21, 21:26

  2. core-ci voted on patch set 1 V +1 05/12/21, 21:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11462

  3. Oli Bartsch voted on patch set 1 CR +1 05/14/21, 13:17

  4. Andreas Kienast commented on patch set 1 CR -1 05/14/21, 13:26

    on it
  5. Andreas Kienast uploaded patch set 2 05/14/21, 13:32

  6. core-ci voted on patch set 2 V +1 05/14/21, 13:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11518

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 05/14/21, 15:54

  8. Richard Haeser voted on patch set 2 CR +1 05/17/21, 07:48

  9. Christian Kuhn commented on patch set 2 CR -1 05/17/21, 11:44

    on it.
  10. Christian Kuhn voted on patch set 2 V +1 CR +1 05/17/21, 13:06

  11. Benni Mack voted on patch set 2 V +2 CR +2 05/17/21, 13:57

  12. Benni Mack merged patch set 3 05/17/21, 14:39