69139[TASK] Render TS and pageTS snippets with CodeMirror
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 14
- Build/Sources/Sass/editor.scss+10 −0
- Build/Sources/TypeScript/t3editor/Resources/Public/TypeScript/Element/CodeMirrorElement.ts+48 −7
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+6 −240
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+0 −95
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+55 −8
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/Page.html+1 −8
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php2+1 −0
- typo3/sysext/t3editor/Resources/Public/Css/t3editor.css+1 −1
- typo3/sysext/t3editor/Resources/Public/JavaScript/Element/CodeMirrorElement.js+3 −3
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerModuleFunctionController.php+155 −144
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+1 −1
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_analyzer.xlf+0 −21
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateAnalyzerModuleFunction.html+6 −24
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateObjectBrowserModuleFunction.html+1 −1
Review log 1622
-
Benjamin Franzke uploaded patch set 1 05/13/21, 00:01
-
core-ci voted on patch set 1 V +1 05/13/21, 00:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11465
-
Benjamin Franzke uploaded patch set 2 05/17/21, 21:39
-
core-ci voted on patch set 2 V +1 05/17/21, 21:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11605
-
Christian Kuhn uploaded patch set 3 05/20/21, 08:47
-
Christian Kuhn commented on patch set 3 05/20/21, 08:48
rebased. -
core-ci voted on patch set 3 V +1 05/20/21, 08:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11698
-
Christian Kuhn uploaded patch set 4 05/20/21, 12:19
-
core-ci voted on patch set 4 V +1 05/20/21, 12:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11709
-
Benni Mack marked it ready for review 05/20/21, 12:37
-
Benjamin Franzke commented on patch set 4 CR -1 05/20/21, 12:55
T3editorElement.php:109We need to re-add this line to patchset 4, otherwise the switch to the `change` event in CodeMirrorElement.ts wouldn't be catched by FormEngineValidation (in only listens for change event on elements that contain this attribute). -
Benjamin Franzke uploaded patch set 5 05/20/21, 12:59
-
Benjamin Franzke commented on patch set 5 05/20/21, 12:59
T3editorElement.php:109ReplyDone -
core-ci voted on patch set 5 V +1 05/20/21, 13:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11710
-
Christian Kuhn voted on patch set 5 V +1 CR +1 05/20/21, 13:22
-
Oliver Klee commented on patch set 5 05/20/21, 13:40
Really love the commit message! <3 -
Oli Bartsch uploaded patch set 6 05/20/21, 13:48
-
Oli Bartsch voted on patch set 6 V +1 CR +1 05/20/21, 13:48
-
Christian Kuhn voted on patch set 6 V +1 CR +1 05/20/21, 13:50
-
core-ci voted on patch set 6 V +1 05/20/21, 13:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11713
-
Benjamin Franzke voted on patch set 6 V +2 CR +2 05/20/21, 13:57
-
Benjamin Franzke merged patch set 7 05/20/21, 13:57