Review main Merged

69139[TASK] Render TS and pageTS snippets with CodeMirror

Benjamin Franzke CR +2 V +2 Hard +288 −553 updated 05/20/21, 13:57

Commit message

The TypoScript parser has a built in syntax hightlighter.
This is used by ext:tstemplate template analyzer and a sub
section of ext:info PageTsConfig.

We however have a much better syntax highlighter: t3editor.

The patch commits some long overdue love to the template
analyzer to use CodeMirror rendering for TypoScript
snippets. It kicks in if t3editor is loaded, otherwise a
textarea is rendered.

This allows to drop a metric ton of horky borky code from
TypoScriptParser and friends - enabling further refactorings
that may eventually end up with performance improvements
in some happy future?

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1622

  1. Benjamin Franzke uploaded patch set 1 05/13/21, 00:01

  2. core-ci voted on patch set 1 V +1 05/13/21, 00:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11465

  3. Benjamin Franzke uploaded patch set 2 05/17/21, 21:39

  4. core-ci voted on patch set 2 V +1 05/17/21, 21:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11605

  5. Christian Kuhn uploaded patch set 3 05/20/21, 08:47

  6. Christian Kuhn commented on patch set 3 05/20/21, 08:48

    rebased.
  7. core-ci voted on patch set 3 V +1 05/20/21, 08:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11698

  8. Christian Kuhn uploaded patch set 4 05/20/21, 12:19

  9. core-ci voted on patch set 4 V +1 05/20/21, 12:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11709

  10. Benni Mack marked it ready for review 05/20/21, 12:37

  11. Benjamin Franzke commented on patch set 4 CR -1 05/20/21, 12:55

    T3editorElement.php:109

    We need to re-add this line to patchset 4, otherwise the switch to the `change` event in CodeMirrorElement.ts wouldn't be catched by FormEngineValidation (in only listens for change event on elements that contain this attribute).
  12. Benjamin Franzke uploaded patch set 5 05/20/21, 12:59

  13. Benjamin Franzke commented on patch set 5 05/20/21, 12:59

    T3editorElement.php:109 Reply

    Done
  14. core-ci voted on patch set 5 V +1 05/20/21, 13:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11710

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 05/20/21, 13:22

  16. Oliver Klee commented on patch set 5 05/20/21, 13:40

    Really love the commit message! <3
  17. Oli Bartsch uploaded patch set 6 05/20/21, 13:48

  18. Oli Bartsch voted on patch set 6 V +1 CR +1 05/20/21, 13:48

  19. Christian Kuhn voted on patch set 6 V +1 CR +1 05/20/21, 13:50

  20. core-ci voted on patch set 6 V +1 05/20/21, 13:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11713

  21. Benjamin Franzke voted on patch set 6 V +2 CR +2 05/20/21, 13:57

  22. Benjamin Franzke merged patch set 7 05/20/21, 13:57