Review main Merged

69142[TASK] Initialize Install Tool layout without inline JavaScript

Benjamin Franzke CR +2 V +2 Easy +9 −16 updated 05/17/21, 11:10

Commit message

Pass startup module and bust parameter as data tags
to avoid inline javascript initialization.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Benjamin Franzke uploaded patch set 1 05/13/21, 14:05

  2. Benjamin Franzke wrote 05/13/21, 14:11

    Topic set to inline-javascript
  3. core-ci voted on patch set 1 V +1 05/13/21, 14:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11477

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 05/14/21, 14:33

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 05/17/21, 11:10

  6. Christian Kuhn merged patch set 2 05/17/21, 11:10