Review main Merged

69143[TASK] Switch behavior of ArrayUtility::arrayDiffAssocRecursive()

Andreas Kienast CR +2 V +2 Normal +219 −17 updated 05/14/21, 12:51

Commit message

Despite its name, the method `ArrayUtility::arrayDiffAssocRecursive()`
mimics the behavior of `array_diff_key()` and not of
`array_diff_assoc()`.

The method has been adjusted to act like `array_diff_assoc()`. As this is
considered being a breaking change, the behavior must be enabled
explicitly by passing a 3rd parameter `$useArrayDiffAssocBehavior` being
true. If the argument is either omitted or false, the old behavior is kept
but a deprecation warning will be thrown.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Richard Haeser +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1217

  1. Andreas Kienast uploaded patch set 1 05/13/21, 14:50

  2. Andreas Kienast commented on patch set 1 05/13/21, 14:51

    The idea of backporting this patch to 10.4 is to offer a forward compatibility approach, of course without deprecation!
  3. Andreas Kienast uploaded patch set 2 05/13/21, 14:53

  4. core-ci voted on patch set 1 V +1 05/13/21, 14:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11478

  5. core-ci voted on patch set 2 V +1 05/13/21, 15:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11479

  6. Benni Mack voted on patch set 2 CR +1 05/14/21, 09:31

  7. Andreas Kienast uploaded patch set 3 05/14/21, 09:32

  8. core-ci voted on patch set 3 V +1 05/14/21, 09:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11494

  9. Oli Bartsch uploaded patch set 4 05/14/21, 11:40

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 05/14/21, 11:41

  11. core-ci voted on patch set 4 V +1 05/14/21, 11:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11509

  12. Oli Bartsch uploaded patch set 5 05/14/21, 12:27

  13. Oli Bartsch voted on patch set 5 V +1 CR +1 05/14/21, 12:28

  14. core-ci voted on patch set 5 V +1 05/14/21, 12:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11511

  15. Richard Haeser voted on patch set 5 V +1 CR +1 05/14/21, 12:48

  16. Andreas Kienast voted on patch set 5 V +2 CR +2 05/14/21, 12:51

  17. Andreas Kienast merged patch set 6 05/14/21, 12:51