Review main Merged

69144[BUGFIX] Normalize UTF-8 strings before calling CharsetConverter->specCharsToASCII()

Martin Kutschker CR +2 V +2 Easy +31 −3 updated 06/17/21, 11:11

Commit message

The method specCharsToASCII expects its input in Canonical Composition (NFC) otherwise it will produce incorrect results.

The commit also makes sure that a failed normalization (incl. the slug helper) does not lead to data loss.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • Richard Haeser +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1620

  1. Martin Kutschker uploaded patch set 1 05/13/21, 18:21

  2. core-ci voted on patch set 1 V -1 05/13/21, 18:30 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11480

  3. Martin Kutschker uploaded patch set 2 05/13/21, 18:50

  4. core-ci voted on patch set 2 V -1 05/13/21, 18:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11481

  5. Martin Kutschker uploaded patch set 3 05/13/21, 19:16

  6. core-ci voted on patch set 3 V +1 05/13/21, 19:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11482

  7. Xavier Perseguers voted on patch set 3 CR +1 06/14/21, 08:50

  8. Benni Mack voted on patch set 3 CR +1 06/14/21, 09:03

  9. Markus Klein voted on patch set 3 CR +1 06/14/21, 09:12

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 06/14/21, 10:35

  11. Richard Haeser voted on patch set 3 CR +1 06/15/21, 14:06

  12. Anja Leichsenring commented on patch set 4 06/15/21, 16:42

    Published edit on patch set 3.
  13. core-ci voted on patch set 4 V +1 06/15/21, 16:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12455

  14. Richard Haeser voted on patch set 4 CR +1 06/15/21, 17:07

  15. crell commented on patch set 4 06/15/21, 17:12

    LocalDriver.php:320

    Possibly naive question: Why not just type the parameter in the first place? Manual casting is 90% of the time a code smell.
  16. Martin Kutschker commented on patch set 4 06/15/21, 18:09

    LocalDriver.php:320 Reply

    Because I would have to change the signature. I simply feared to break things. I want to the see the patch in v10 and I don't think that typing should be introduced there. Things are bound to break. I don't think I am qualified to decide. I don't even know the stragey: type only new code, type en passant, do dedicated type patches....
  17. Markus Klein voted on patch set 4 CR +1 06/16/21, 07:21

  18. Christian Kuhn commented on patch set 4 V +1 CR +1 06/16/21, 16:08

    LocalDriver.php:320 Reply

    Ack
  19. Anja Leichsenring voted on patch set 4 V +2 CR +2 06/17/21, 11:11

  20. Anja Leichsenring merged patch set 5 06/17/21, 11:11