Review main Merged

69147[BUGFIX] Respect icon size defined by tree

Benjamin Kott CR +2 V +2 Normal +47 −21 updated 05/14/21, 10:14

Commit message

The SVG Tree now builds a SVG-in-SVG element around all
icons (icon + overlay) to ensure the sizes are consistent
and can be positioned properly.

This fixes the issue that possible custom icons have
a different size.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Benjamin Kott uploaded patch set 1 05/14/21, 09:46

  2. Benni Mack updated the commit message in patch set 2 05/14/21, 09:53

  3. core-ci voted on patch set 1 V +1 05/14/21, 09:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11497

  4. core-ci voted on patch set 2 V +1 05/14/21, 10:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11499

  5. Benni Mack uploaded patch set 3 05/14/21, 10:01

  6. core-ci voted on patch set 3 V +1 05/14/21, 10:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11500

  7. Benni Mack voted on patch set 3 V +1 CR +1 05/14/21, 10:11

  8. Andreas Kienast voted on patch set 3 V +2 CR +2 05/14/21, 10:14

  9. Andreas Kienast merged patch set 4 05/14/21, 10:14