Review main Merged

69149[FEATURE] Possibility to refresh dashboard widgets

Richard Haeser CR +2 V +2 Hard +285 −34 updated 05/18/21, 08:54

Commit message

For some widgets it makes sense for users to be able to refresh the widget
without reloading the complete dashboard. A new refresh action will be
available on widgets which have the refresh option enabled.

Besides that, a new event is created so developers can dispatch an
event to refresh a specific widget even when no refresh option
is available for the user.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 2131

Show 46 earlier messages
  1. Richard Haeser uploaded patch set 1 05/14/21, 10:12

  2. core-ci voted on patch set 1 V +1 05/14/21, 10:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11502

  3. Richard Haeser uploaded patch set 2 05/14/21, 11:39

  4. Richard Haeser commented on patch set 2 05/14/21, 11:39

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 05/14/21, 11:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11508

  6. Richard Haeser commented on patch set 2 CR -2 05/14/21, 12:16

    Unresolved

    Hmm, by changing the constructor of the configuration option, this will make it hard for extension devs to create a widget which will work in v10 as well as v11. Will change this.
  1. Oli Bartsch uploaded patch set 3 05/14/21, 12:21

  2. core-ci voted on patch set 3 V +1 05/14/21, 12:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11510

  3. Richard Haeser uploaded patch set 4 05/14/21, 13:15

  4. Richard Haeser uploaded patch set 5 05/14/21, 13:23

  5. Richard Haeser voted on patch set 5 CR 0 05/14/21, 13:23

  6. Richard Haeser voted on patch set 5 CR -1 05/14/21, 13:23

  7. core-ci voted on patch set 4 V -1 05/14/21, 13:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11515

  8. Richard Haeser uploaded patch set 6 05/14/21, 13:26

  9. core-ci voted on patch set 5 V -1 05/14/21, 13:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11516

  10. core-ci voted on patch set 6 V -1 05/14/21, 13:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11517

  11. Richard Haeser uploaded patch set 7 05/14/21, 13:37

  12. core-ci voted on patch set 7 V -1 05/14/21, 13:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11519

  13. Richard Haeser uploaded patch set 8 05/14/21, 13:50

  14. core-ci voted on patch set 8 V +1 05/14/21, 13:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11520

  15. Oli Bartsch commented on patch set 8 05/14/21, 14:06

    Dashboard.php:122

    Would like to cover this with an interface in some way, as for the other methods (e.g. RequireJsModuleInferface, AdditionalCssInterface). Actually best would be to extended the WidgetInterface but this would be breaking I guess. What we could do (as we already did in some other patches), add the method to the WidgetInterface but comment this out for v11. What do you think?
  16. Richard Haeser commented on patch set 8 05/14/21, 14:09

    Dashboard.php:122 Reply

    Yeah, that would be a good idea. I also had a deprecation message before at this location, but having it commented out for v11 in the WidgetInterface would be ok for me. Having another interface doesn't make that much sense as all widgets should have this method IMHO so WidgetInterface is the right place. I will add it to the interface
  17. Richard Haeser uploaded patch set 9 05/14/21, 14:13

  18. Richard Haeser commented on patch set 9 05/14/21, 14:14

    Dashboard.php:122 Reply

    Done
  19. core-ci voted on patch set 9 V +1 05/14/21, 14:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11521

  20. Oli Bartsch uploaded patch set 10 05/14/21, 15:19

  21. Oli Bartsch voted on patch set 10 V +1 CR +1 05/14/21, 15:21

  22. core-ci voted on patch set 10 V +1 05/14/21, 15:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11523

  23. Jochen Roth voted on patch set 10 V +1 CR +1 05/18/21, 08:31

  24. Oli Bartsch voted on patch set 10 V +2 CR +2 05/18/21, 08:53

  25. Oli Bartsch merged patch set 11 05/18/21, 08:54