69149[FEATURE] Possibility to refresh dashboard widgets
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 18
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/WidgetContentCollector.ts+54 −32
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/WidgetRefresh.tsnew+39 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-93210-PossibilityToRefreshDashboardWidgets.rstnew+82 −0
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+1 −0
- typo3/sysext/dashboard/Classes/DependencyInjection/DashboardWidgetPass.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/BarChartWidget.php+8 −0
- typo3/sysext/dashboard/Classes/Widgets/CtaWidget.php+8 −0
- typo3/sysext/dashboard/Classes/Widgets/DoughnutChartWidget.php+8 −0
- typo3/sysext/dashboard/Classes/Widgets/ListWidget.php+8 −0
- typo3/sysext/dashboard/Classes/Widgets/NumberWithIconWidget.php+8 −0
- typo3/sysext/dashboard/Classes/Widgets/RssWidget.php+8 −0
- typo3/sysext/dashboard/Classes/Widgets/T3GeneralInformationWidget.php+8 −0
- typo3/sysext/dashboard/Classes/Widgets/WidgetInterface.php+11 −0
- typo3/sysext/dashboard/Classes/Dashboard.php3+18 −0
- typo3/sysext/dashboard/Configuration/Backend/DashboardWidgets.yaml+2 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html+7 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetContentCollector.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetRefresh.jsnew+13 −0
Review log 2131
Show 46 earlier messages
-
Richard Haeser uploaded patch set 1 05/14/21, 10:12
-
core-ci voted on patch set 1 V +1 05/14/21, 10:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11502
-
Richard Haeser uploaded patch set 2 05/14/21, 11:39
-
Richard Haeser commented on patch set 2 05/14/21, 11:39
This change is ready for review. -
core-ci voted on patch set 2 V +1 05/14/21, 11:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11508
-
Richard Haeser commented on patch set 2 CR -2 05/14/21, 12:16
Unresolved
Hmm, by changing the constructor of the configuration option, this will make it hard for extension devs to create a widget which will work in v10 as well as v11. Will change this.
-
Oli Bartsch uploaded patch set 3 05/14/21, 12:21
-
core-ci voted on patch set 3 V +1 05/14/21, 12:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11510
-
Richard Haeser uploaded patch set 4 05/14/21, 13:15
-
Richard Haeser uploaded patch set 5 05/14/21, 13:23
-
Richard Haeser voted on patch set 5 CR 0 05/14/21, 13:23
-
Richard Haeser voted on patch set 5 CR -1 05/14/21, 13:23
-
core-ci voted on patch set 4 V -1 05/14/21, 13:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11515
-
Richard Haeser uploaded patch set 6 05/14/21, 13:26
-
core-ci voted on patch set 5 V -1 05/14/21, 13:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11516
-
core-ci voted on patch set 6 V -1 05/14/21, 13:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11517
-
Richard Haeser uploaded patch set 7 05/14/21, 13:37
-
core-ci voted on patch set 7 V -1 05/14/21, 13:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11519
-
Richard Haeser uploaded patch set 8 05/14/21, 13:50
-
core-ci voted on patch set 8 V +1 05/14/21, 13:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11520
-
Oli Bartsch commented on patch set 8 05/14/21, 14:06
Dashboard.php:122Would like to cover this with an interface in some way, as for the other methods (e.g. RequireJsModuleInferface, AdditionalCssInterface). Actually best would be to extended the WidgetInterface but this would be breaking I guess. What we could do (as we already did in some other patches), add the method to the WidgetInterface but comment this out for v11. What do you think? -
Richard Haeser commented on patch set 8 05/14/21, 14:09
Dashboard.php:122ReplyYeah, that would be a good idea. I also had a deprecation message before at this location, but having it commented out for v11 in the WidgetInterface would be ok for me. Having another interface doesn't make that much sense as all widgets should have this method IMHO so WidgetInterface is the right place. I will add it to the interface -
Richard Haeser uploaded patch set 9 05/14/21, 14:13
-
Richard Haeser commented on patch set 9 05/14/21, 14:14
Dashboard.php:122ReplyDone -
core-ci voted on patch set 9 V +1 05/14/21, 14:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11521
-
Oli Bartsch uploaded patch set 10 05/14/21, 15:19
-
Oli Bartsch voted on patch set 10 V +1 CR +1 05/14/21, 15:21
-
core-ci voted on patch set 10 V +1 05/14/21, 15:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11523
-
Jochen Roth voted on patch set 10 V +1 CR +1 05/18/21, 08:31
-
Oli Bartsch voted on patch set 10 V +2 CR +2 05/18/21, 08:53
-
Oli Bartsch merged patch set 11 05/18/21, 08:54