Review 10.4 Merged

69150[TASK] Switch behavior of ArrayUtility::arrayDiffAssocRecursive()

Andreas Kienast CR +2 V +2 Normal +163 −17 updated 05/14/21, 13:37

Commit message

Despite its name, the method `ArrayUtility::arrayDiffAssocRecursive()`
mimics the behavior of `array_diff_key()` and not of
`array_diff_assoc()`.

The method has been adjusted to act like `array_diff_assoc()`. As this is
considered being a breaking change, the behavior must be enabled
explicitly by passing a 3rd parameter `$useArrayDiffAssocBehavior` being
true. For forward compatibility reasons, this patch is backported from
master branch without any deprecation in place.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 34

  1. Andreas Kienast uploaded patch set 1 05/14/21, 12:56

  2. core-ci voted on patch set 1 V +1 05/14/21, 13:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11513

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 05/14/21, 13:37

  4. Andreas Kienast merged patch set 2 05/14/21, 13:37