Review main Merged

69152[TASK] Resolve more PHP 8 acceptance tests

crell CR +2 V +2 Hard +149 −134 updated 05/20/21, 20:46

Commit message

More array type mishandling correction.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • core-ci +1 CI

Issues 1

Files 40

Show 20 more files

Review log 2538

Show 713 earlier messages
  1. crell uploaded patch set 1 05/14/21, 15:55

  2. core-ci voted on patch set 1 V -1 05/14/21, 15:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11525

  3. Oliver Klee commented on patch set 1 05/14/21, 17:09

    UserFunctions.php:42

    This probably should get an int cast, and have a default of 0.
  4. crell uploaded patch set 2 05/14/21, 18:28

  5. core-ci voted on patch set 2 V -1 05/14/21, 18:30 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11526

  6. crell uploaded patch set 3 05/15/21, 00:00

  7. core-ci voted on patch set 3 V -1 05/15/21, 00:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11534

  8. crell uploaded patch set 4 05/17/21, 14:33

  9. core-ci voted on patch set 4 V -1 05/17/21, 14:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11592

  10. crell uploaded patch set 5 05/17/21, 16:53

  11. core-ci voted on patch set 5 V -1 05/17/21, 17:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11595

  12. crell uploaded patch set 6 05/18/21, 00:24

  13. core-ci voted on patch set 6 V -1 05/18/21, 00:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11606

  1. crell uploaded patch set 7 05/18/21, 13:39

  2. core-ci voted on patch set 7 V -1 05/18/21, 13:51 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11619

  3. crell commented on patch set 7 05/18/21, 13:52

    UserFunctions.php:42 Reply

    Done
  4. Markus Klein commented on patch set 7 05/18/21, 14:47

    BackendUtility.php:2757

    no need for ?? here, we are already within an isset()
  5. Markus Klein commented on patch set 7 05/18/21, 14:53

    InlineRecordContainer.php:638

    Is it safe to do so? Does some other code maybe relay on this being unset?

    SelectIcons.php:52

    extra surrounding () are not needed and make things harder to read (IMO)
  6. crell uploaded patch set 8 05/18/21, 17:20

  7. core-ci voted on patch set 8 V -1 05/18/21, 17:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11631

  8. crell commented on patch set 8 05/18/21, 20:31

    InlineRecordContainer.php:638 Reply

    Turns out it wasn't.

    SelectIcons.php:52 Reply

    Done

    BackendUtility.php:2757 Reply

    Done
  9. crell uploaded patch set 9 05/18/21, 20:31

  10. core-ci voted on patch set 9 V -1 05/18/21, 20:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11637

  11. Oliver Klee wrote 05/19/21, 09:37

    Removed reviewer Oliver Klee.
  12. crell uploaded patch set 10 05/20/21, 13:06

  13. core-ci voted on patch set 10 V +1 05/20/21, 13:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11711

  14. crell rebased onto patch set 11 05/20/21, 14:42

  15. core-ci voted on patch set 11 V +1 05/20/21, 14:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11720

  16. Benni Mack commented on patch set 11 05/20/21, 15:08

    SiteTcaInline.php:308 Unresolved

    I guess this should be an integer, not "false"

    SiteTcaInline.php:309 Unresolved

    I think this should be a string (empty)

    SiteTcaInline.php:310 Unresolved

    i think this should be an empty string instead of false
  17. Benni Mack uploaded patch set 12 05/20/21, 16:26

  18. core-ci voted on patch set 12 V +1 05/20/21, 16:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11726

  19. Benni Mack voted on patch set 12 V +1 05/20/21, 16:59

  20. Benni Mack uploaded patch set 13 05/20/21, 17:32

  21. Benni Mack voted on patch set 13 V +1 CR +1 05/20/21, 17:33

  22. core-ci voted on patch set 13 V +1 05/20/21, 17:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11733

  23. Richard Haeser voted on patch set 13 V +1 CR +1 05/20/21, 20:42

  24. Benni Mack voted on patch set 13 V +2 CR +2 05/20/21, 20:46

  25. Benni Mack merged patch set 14 05/20/21, 20:46