69152[TASK] Resolve more PHP 8 acceptance tests
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Richard Haeser +1
-
Verified V +2 Done
- Benni Mack +2
- Richard Haeser +1
- core-ci +1 CI
Issues 1
Files 40
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+4 −4
- typo3/sysext/backend/Classes/Configuration/TCA/UserFunctions.php2+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+4 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+9 −9
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LogoutController.php+1 −1
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+7 −11
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+7 −3
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php2+28 −16
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+8 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+4 −0
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+3 −3
- typo3/sysext/backend/Classes/Form/FieldWizard/SelectIcons.php2+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php3+3 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+6 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineIsOnSymmetricSide.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+1 −1
- typo3/sysext/backend/Classes/Form/AbstractNode.php+1 −1
Show 20 more files
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+2 −1
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+2 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+4 −4
- typo3/sysext/core/Classes/Database/RelationHandler.php+2 −2
- typo3/sysext/core/Classes/FormProtection/AbstractFormProtection.php+1 −9
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+8 −8
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+4 −4
- typo3/sysext/core/Tests/Unit/FormProtection/AbstractFormProtectionTest.php+0 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+3 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+7 −7
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −2
- typo3/sysext/recordlist/Classes/View/FolderUtilityRenderer.php+2 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+1 −1
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+2 −2
- typo3/sysext/rte_ckeditor/Classes/Form/Resolver/RichTextNodeResolver.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+7 −7
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+4 −4
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+1 −1
Review log 2538
Show 713 earlier messages
-
crell uploaded patch set 1 05/14/21, 15:55
-
core-ci voted on patch set 1 V -1 05/14/21, 15:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11525
-
Oliver Klee commented on patch set 1 05/14/21, 17:09
-
crell uploaded patch set 2 05/14/21, 18:28
-
core-ci voted on patch set 2 V -1 05/14/21, 18:30 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11526
-
crell uploaded patch set 3 05/15/21, 00:00
-
core-ci voted on patch set 3 V -1 05/15/21, 00:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11534
-
crell uploaded patch set 4 05/17/21, 14:33
-
core-ci voted on patch set 4 V -1 05/17/21, 14:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11592
-
crell uploaded patch set 5 05/17/21, 16:53
-
core-ci voted on patch set 5 V -1 05/17/21, 17:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11595
-
crell uploaded patch set 6 05/18/21, 00:24
-
core-ci voted on patch set 6 V -1 05/18/21, 00:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11606
-
crell uploaded patch set 7 05/18/21, 13:39
-
core-ci voted on patch set 7 V -1 05/18/21, 13:51 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11619
-
crell commented on patch set 7 05/18/21, 13:52
UserFunctions.php:42ReplyDone -
Markus Klein commented on patch set 7 05/18/21, 14:47
BackendUtility.php:2757no need for ?? here, we are already within an isset() -
Markus Klein commented on patch set 7 05/18/21, 14:53
InlineRecordContainer.php:638Is it safe to do so? Does some other code maybe relay on this being unset?SelectIcons.php:52extra surrounding () are not needed and make things harder to read (IMO) -
crell uploaded patch set 8 05/18/21, 17:20
-
core-ci voted on patch set 8 V -1 05/18/21, 17:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11631
-
crell commented on patch set 8 05/18/21, 20:31
InlineRecordContainer.php:638ReplyTurns out it wasn't.SelectIcons.php:52ReplyDoneBackendUtility.php:2757ReplyDone -
crell uploaded patch set 9 05/18/21, 20:31
-
core-ci voted on patch set 9 V -1 05/18/21, 20:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11637
-
Oliver Klee wrote 05/19/21, 09:37
Removed reviewer Oliver Klee. -
crell uploaded patch set 10 05/20/21, 13:06
-
core-ci voted on patch set 10 V +1 05/20/21, 13:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11711
-
crell rebased onto patch set 11 05/20/21, 14:42
-
core-ci voted on patch set 11 V +1 05/20/21, 14:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11720
-
Benni Mack commented on patch set 11 05/20/21, 15:08
SiteTcaInline.php:308UnresolvedI guess this should be an integer, not "false"SiteTcaInline.php:309UnresolvedI think this should be a string (empty)SiteTcaInline.php:310Unresolvedi think this should be an empty string instead of false -
Benni Mack uploaded patch set 12 05/20/21, 16:26
-
core-ci voted on patch set 12 V +1 05/20/21, 16:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11726
-
Benni Mack voted on patch set 12 V +1 05/20/21, 16:59
-
Benni Mack uploaded patch set 13 05/20/21, 17:32
-
Benni Mack voted on patch set 13 V +1 CR +1 05/20/21, 17:33
-
core-ci voted on patch set 13 V +1 05/20/21, 17:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11733
-
Richard Haeser voted on patch set 13 V +1 CR +1 05/20/21, 20:42
-
Benni Mack voted on patch set 13 V +2 CR +2 05/20/21, 20:46
-
Benni Mack merged patch set 14 05/20/21, 20:46
UserFunctions.php:42