Review main Merged

69157[FEATURE] Show creation date of redirects

Oli Bartsch CR +2 V +2 Easy +48 −1 updated 05/18/21, 08:44

Commit message

To improve the usability of the "Redirects hit count"
feature, the creation date is now also shown in the
"Statistics" tab.

This is especially useful to set the amount of hits in
relation to the period of the redirect existence.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Oli Bartsch uploaded patch set 1 05/17/21, 10:08

  2. core-ci voted on patch set 1 V +1 05/17/21, 10:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11583

  3. Georg Ringer commented on patch set 1 05/17/21, 12:58

    Don't we have that not already translated multiple times somewhere?
  4. Richard Haeser uploaded patch set 2 05/17/21, 20:34

  5. Richard Haeser commented on patch set 2 V +1 CR +1 05/17/21, 20:35

    Reply

    Agree. LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.creationDate is used in other places for this, so I updated the patch
  6. core-ci voted on patch set 2 V +1 05/17/21, 20:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11600

  7. Oli Bartsch commented on patch set 3 05/18/21, 07:54

    Published edit on patch set 2.
  8. Richard Haeser voted on patch set 3 V +1 CR +1 05/18/21, 07:56

  9. core-ci voted on patch set 3 V +1 05/18/21, 08:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11612

  10. Jochen Roth voted on patch set 3 V +1 CR +1 05/18/21, 08:43

  11. Richard Haeser voted on patch set 3 V +2 CR +2 05/18/21, 08:44

  12. Richard Haeser merged patch set 4 05/18/21, 08:44