Review main Merged

69158[TASK] Streamline routing related phpDoc comments & annotations

Oliver Hader CR +2 V +2 Normal +40 −27 updated 05/21/21, 09:26

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 67

  1. Oliver Hader uploaded patch set 1 05/17/21, 15:21

  2. core-ci voted on patch set 1 V +1 05/17/21, 15:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11594

  3. Benni Mack voted on patch set 1 V +1 CR +1 05/17/21, 19:28

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 05/17/21, 19:40

  5. Oliver Hader voted on patch set 1 V +2 CR +2 05/17/21, 21:02

  6. Oliver Hader merged patch set 2 05/17/21, 21:02

  7. Oliver Hader commented on patch set 2 05/21/21, 09:26

    Post -1 again - discovered another flaw

    SimpleEnhancer.php:67 Unresolved

    -1 unfortunately, that's still not correct...