69158[TASK] Streamline routing related phpDoc comments & annotations
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Routing/Enhancer/PluginEnhancer.php+1 −1
- typo3/sysext/core/Classes/Routing/Enhancer/SimpleEnhancer.php1+2 −2
- typo3/sysext/core/Classes/Routing/PageArguments.php+30 −17
- typo3/sysext/core/Documentation/Changelog/10.3/Deprecation-89868-RemoveReqCHashFunctionalityForPlugins.rst+1 −1
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php+6 −6
Review log 67
-
Oliver Hader uploaded patch set 1 05/17/21, 15:21
-
core-ci voted on patch set 1 V +1 05/17/21, 15:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11594
-
Benni Mack voted on patch set 1 V +1 CR +1 05/17/21, 19:28
-
Oli Bartsch voted on patch set 1 V +1 CR +1 05/17/21, 19:40
-
Oliver Hader voted on patch set 1 V +2 CR +2 05/17/21, 21:02
-
Oliver Hader merged patch set 2 05/17/21, 21:02
-
Oliver Hader commented on patch set 2 05/21/21, 09:26
Post -1 again - discovered another flawSimpleEnhancer.php:67Unresolved-1 unfortunately, that's still not correct...