Review main Merged

69162[TASK] Streamline spinner web component size and animation

Benjamin Franzke CR +2 V +2 Normal +98 −59 updated 05/19/21, 14:16

Commit message

This change performs the following optimizations:

* Detach spinner from content flow using a relative+absolute
  position normalization, allowing an equivalent positioning
  to the regular backend icons.
  This is to ensure that both, <typo3-backend-spinner> and
  <typo3-backend-icon> render equally when used in inline(-block)
  containers (for example .svg-toolbar__drag-node).
  <typo3-backend-spinner> used to cause vertical alignment offsets,
  when the spinner was positioned in inline text-flow and therefore
  caused the vertical flow to cause offsets.

* Add a variant="light|dark" attribute to select
  between the available TYPO3 spinner variants.
  By default the current color is now used.

* Adapt sizing to inherit size from current font-size when used
  without a specific size attribute. Also apply that to the
  backend icon component to stay interchangeable.

* Render spinner via SVG and only animate the spinning part
  instead of the entire shape. This is to avoid the bouncing-icon
  effect that CSS animations on the entire element cause
  (as often seen with font-awesome spinners for example).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 79

  1. Benjamin Franzke uploaded patch set 1 05/17/21, 21:24

  2. core-ci voted on patch set 1 V +1 05/17/21, 21:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11604

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 05/19/21, 10:33

  4. Oli Bartsch updated the commit message in patch set 2 05/19/21, 11:21

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 05/19/21, 11:21

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 05/19/21, 11:22

  7. core-ci voted on patch set 2 V +1 05/19/21, 11:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11670

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 05/19/21, 14:16

  9. Benjamin Franzke merged patch set 3 05/19/21, 14:16