Review main Merged

69172[TASK] Set proper title of window in backend

Richard Haeser CR +2 V +2 Normal +194 −21 updated 09/07/21, 19:58

Commit message

With the introduction of the new backend module web component router,
the title of the backend windows will be set to the title of the
main iframe. Most of the modules didn't provide a proper name though.

For most modules we have a proper name now which will show up in the
title of the backend window, if no title is propagated by the module,
the backend router will fallback to the default backend title.

As the format of the title is quite "personal". If you are used to have
opened more TYPO3 backend windows, you would like to see which
installation you have open. If you only work in one backend, you
might want to see on which module you are currently working. It is
possible to set the order of the title of the backend within your
user settings now. By default it will be title - siteName [version]

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 35

Show 15 more files

Review log 2235

Show 510 earlier messages
  1. Richard Haeser uploaded patch set 1 05/18/21, 09:31

  2. Richard Haeser uploaded patch set 2 05/18/21, 09:36

  3. core-ci voted on patch set 1 V -1 05/18/21, 09:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11613

  4. core-ci voted on patch set 2 V -1 05/18/21, 09:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11614

  5. Richard Haeser uploaded patch set 3 05/18/21, 14:25

  6. Richard Haeser uploaded patch set 4 05/18/21, 14:27

  7. core-ci voted on patch set 3 V -1 05/18/21, 14:36 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11622

  8. core-ci voted on patch set 4 V -1 05/18/21, 14:36 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11623

  9. Richard Haeser uploaded patch set 5 05/18/21, 17:45

  10. core-ci voted on patch set 5 V +1 05/18/21, 17:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11632

  1. Richard Haeser uploaded patch set 6 05/20/21, 15:16

  2. core-ci voted on patch set 6 V +1 05/20/21, 15:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11723

  3. Richard Haeser uploaded patch set 7 05/20/21, 20:22

  4. Richard Haeser commented on patch set 7 05/20/21, 20:22

    This change is ready for review.
  5. core-ci voted on patch set 7 V +1 05/20/21, 20:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11747

  6. Benjamin Franzke uploaded patch set 8 05/25/21, 18:39

  7. Benjamin Franzke uploaded patch set 9 05/25/21, 18:41

  8. core-ci voted on patch set 8 V -1 05/25/21, 18:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11846

  9. core-ci voted on patch set 9 V -1 05/25/21, 18:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11847

  10. Benjamin Franzke uploaded patch set 10 05/25/21, 19:30

  11. core-ci voted on patch set 10 V -1 05/25/21, 19:40 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11848

  12. Benjamin Franzke uploaded patch set 11 05/25/21, 19:56

  13. Daniel Siepmann commented on patch set 11 05/25/21, 20:05

    I'm missing title for: * Edit form of a page (record) * Redirects add new entry * Redirects edit entry (most probably generic edit record?) * Filelist edit folder or file (record) * Backend User Listing * Backend User Group Listing * Online users * Scheduler add and edit (record?) * Administration log (belog) Install Tool Modules now have installation name twice, e.g. "typo3-git.localhost DEVELOPMENT [TYPO3 CMS 11.3.0-dev] · Install Tool on site typo3-git.localhost DEVELOPMENT". But they also don't change URL, this might be related and worth a separate patch?
  14. core-ci voted on patch set 11 V +1 05/25/21, 20:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11849

  15. Benjamin Franzke commented on patch set 11 V -1 05/25/21, 20:09

    In order to not forget, currently missing are: * Edit Document Controller (FormEngine) * Indexed Search * Backend User Overview * Log Module * CSH Manual (Help > TYPO3 Documentation) * About module Therefore marking as verified-1 for now. @Richard: Do you have time to look at these?
  16. Benjamin Franzke uploaded patch set 12 05/25/21, 20:36

  17. Benjamin Franzke commented on patch set 12 05/25/21, 20:36

    Reply

    Done.
  18. Benjamin Franzke commented on patch set 12 05/25/21, 20:42

    Reply

    Agree regarding edit-stuff in general, but the edit-context is something for later, as we don't have the proper context right now. Could be added once we have some kind of subroutes (or something similar), WIP patch for that is: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69060 Backend User Listing, Backend User Group Listing and Online users are just "Backend Users" with the latest patchset, as this is based on the module template viewhelper. lolli (Christian Kuhn) wants to replace these (and deprecate the view helper), therefore I'd keep that code this simple right now.
  19. core-ci voted on patch set 12 V +1 05/25/21, 20:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11851

  20. Benjamin Franzke uploaded patch set 13 05/25/21, 20:51

  21. core-ci voted on patch set 13 V +1 05/25/21, 21:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11852

  22. Jochen Roth voted on patch set 13 V +1 CR +1 05/26/21, 12:57

  23. Benjamin Franzke voted on patch set 13 V +2 CR +2 05/26/21, 13:04

  24. Benjamin Franzke merged patch set 14 05/26/21, 13:04

  25. Benni Mack commented on patch set 14 09/07/21, 19:58

    Should have been a feature, as people don't know that they configure this.