Review main Merged

69173[TASK] Deprecate "relativeToCurrentScript" in FAL API

Benni Mack CR +2 V +2 Normal +143 −12 updated 05/26/21, 13:52

Commit message

The additional argument "relativeToCurrentScript" through
out the File Abstraction Layer is a faulty conceptual
implementation from back in the days.

FAL can only build "relativeToCurrentScript" links for
local drivers (and only in some cases). In addition, we've
successfully migrated all logic in Frontend (Site Handling)
and Backend (URL Routing since TYPO3 v11) to be able to
handle absolute links, so this option should be marked as
deprecated and never be used again, as it does not properly
work if we want a true Abstraction Layer logic.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 68

  1. Benni Mack uploaded patch set 1 05/18/21, 11:00

  2. core-ci voted on patch set 1 V +1 05/18/21, 11:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11615

  3. Oli Bartsch uploaded patch set 2 05/25/21, 14:11

  4. core-ci voted on patch set 2 V +1 05/25/21, 14:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11833

  5. Benni Mack voted on patch set 2 V +1 CR +1 05/25/21, 14:51

  6. Jochen Roth voted on patch set 2 V +1 CR +1 05/26/21, 12:30

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 05/26/21, 13:52

  8. Oli Bartsch merged patch set 3 05/26/21, 13:52