69174[FEATURE] Consider all Composer installed extensions as active
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Benjamin Franzke +1
- Jochen Roth +1
- Christian Kuhn +1
-
Verified V +2 Done
- Helmut Hummel +2
- Benjamin Franzke +1
- Jochen Roth +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 33
- Build/composer/public/typo3conf/AdditionalConfiguration.php.distnew+7 −0
- Build/composer/.gitignorenew+11 −0
- Build/composer/composer.dist.json1new+51 −0
- Build/phpunit/UnitTestsBootstrap.php+1 −1
- typo3/sysext/core/Classes/Composer/InstallerScripts.php+5 −1
- typo3/sysext/core/Classes/Composer/PackageArtifactBuilder.phpnew+235 −0
- typo3/sysext/core/Classes/Core/BootService.php+3 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+24 −5
- typo3/sysext/core/Classes/Package/Cache/ComposerPackageArtifact.phpnew+116 −0
- typo3/sysext/core/Classes/Package/Cache/PackageCacheEntry.phpnew+182 −0
- typo3/sysext/core/Classes/Package/Cache/PackageCacheInterface.phpnew+51 −0
- typo3/sysext/core/Classes/Package/Cache/PackageStatesPackageCache.phpnew+85 −0
- typo3/sysext/core/Classes/Package/FailsafePackageManager.php+13 −2
- typo3/sysext/core/Classes/Package/Package.php+24 −5
- typo3/sysext/core/Classes/Package/PackageInterface.php3+5 −0
- typo3/sysext/core/Classes/Package/PackageManager.php+61 −76
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94996-InComposerModeAllExtensionsShouldBeInstalledWithComposer.rstnew+60 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rstnew+74 −0
- typo3/sysext/core/Tests/Acceptance/Application/Cli/CommandCest.php+1 −0
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+4 −1
Show 13 more files
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+11 −0
- typo3/sysext/extensionmanager/Classes/Command/ActivateExtensionCommand.php+11 −0
- typo3/sysext/extensionmanager/Classes/Command/DeactivateExtensionCommand.php+11 −0
- typo3/sysext/extensionmanager/Classes/Command/SetupExtensionsCommand.phpnew+111 −0
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+7 −1
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+7 −6
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+5 −0
- typo3/sysext/extensionmanager/Configuration/Services.yaml2+9 −0
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+32 −21
- typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php+5 −0
- phpstan.neon+24 −0
Review log 4372
Show 2647 earlier messages
-
Helmut Hummel uploaded patch set 1 05/18/21, 11:51
-
core-ci voted on patch set 1 V -1 05/18/21, 11:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11616
-
Helmut Hummel uploaded patch set 2 05/19/21, 10:03
-
core-ci voted on patch set 2 V -1 05/19/21, 10:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11667
-
Helmut Hummel uploaded patch set 3 08/24/21, 23:04
-
core-ci voted on patch set 3 V -1 08/24/21, 23:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15548
-
Benni Mack uploaded patch set 4 08/25/21, 15:12
-
core-ci voted on patch set 4 V -1 08/25/21, 15:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15609
-
Helmut Hummel uploaded patch set 5 08/25/21, 15:20
-
core-ci voted on patch set 5 V -1 08/25/21, 15:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15610
-
Helmut Hummel uploaded patch set 6 08/25/21, 16:09
-
Helmut Hummel uploaded patch set 7 08/25/21, 16:10
-
core-ci voted on patch set 6 V -1 08/25/21, 16:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15612
-
Helmut Hummel uploaded patch set 8 08/25/21, 16:24
-
core-ci voted on patch set 7 V -1 08/25/21, 16:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15613
-
core-ci voted on patch set 8 V -1 08/25/21, 16:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15615
-
Helmut Hummel uploaded patch set 9 08/25/21, 20:45
-
core-ci voted on patch set 9 V -1 08/25/21, 20:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15629
-
Helmut Hummel uploaded patch set 10 08/25/21, 21:13
-
core-ci voted on patch set 10 V -1 08/25/21, 21:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15630
-
Helmut Hummel uploaded patch set 11 08/25/21, 21:46
-
Helmut Hummel uploaded patch set 12 08/25/21, 22:07
-
core-ci voted on patch set 12 V -1 08/25/21, 22:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15633
-
Helmut Hummel uploaded patch set 13 08/25/21, 22:11
-
core-ci voted on patch set 11 V -1 08/25/21, 22:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15632
-
core-ci voted on patch set 13 V -1 08/25/21, 22:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15634
-
Helmut Hummel uploaded patch set 14 08/25/21, 22:31
-
core-ci voted on patch set 14 V +1 08/25/21, 22:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15635
-
Helmut Hummel uploaded patch set 15 08/25/21, 23:24
-
core-ci voted on patch set 15 V +1 08/25/21, 23:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15639
-
Simon Gilli commented on patch set 15 08/26/21, 01:35
Nice one!PackageInterface.php:23Is there a reason not allowing dots as done by composer? See also https://github.com/composer/composer/blob/master/src/Composer/Command/InitCommand.php#L100 -
Helmut Hummel commented on patch set 15 08/26/21, 11:15
PackageInterface.php:23Replyno. in fact we should copy the regex from composer sources to here -
Benjamin Franzke uploaded patch set 16 08/26/21, 12:41
-
Benjamin Franzke commented on patch set 16 08/26/21, 12:41
PackageInterface.php:23ReplyDoneServices.yaml:18We can use the existing `hidden` property using: hidden: "%env(TYPO3:isComposerMode)%" env(TYPO:…) is resolved by TYPO3\CMS\Core\DependencyInjection\EnvVarProcessor from the Environment global. Also see: https://docs.typo3.org/c/typo3/cms-core/11.1/en-us/Changelog/10.2/Important-89764-IncompatibleEnvironmentRelatedDependencyInjectionServicesHaveBeenRemoved.html -
Helmut Hummel commented on patch set 16 08/26/21, 12:46
Services.yaml:18ReplyVery cool, thanks! -
core-ci voted on patch set 16 V +1 08/26/21, 13:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15672
-
Helmut Hummel uploaded patch set 17 08/26/21, 13:01
-
core-ci voted on patch set 17 V +1 08/26/21, 13:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15674
-
Helmut Hummel uploaded patch set 18 08/26/21, 14:07
-
core-ci voted on patch set 18 V +1 08/26/21, 14:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15678
-
Helmut Hummel uploaded patch set 19 08/27/21, 08:17
-
core-ci voted on patch set 19 V -1 08/27/21, 08:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15706
-
Helmut Hummel uploaded patch set 20 08/27/21, 08:40
-
core-ci voted on patch set 20 V -1 08/27/21, 08:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15708
-
Helmut Hummel uploaded patch set 21 08/27/21, 08:56
-
core-ci voted on patch set 21 V +1 08/27/21, 09:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15709
-
Helmut Hummel commented on patch set 21 CR -2 08/27/21, 10:05
The last set is broken. will fix asap
-
Helmut Hummel uploaded patch set 22 08/27/21, 10:32
-
Helmut Hummel uploaded patch set 23 08/27/21, 10:49
-
core-ci voted on patch set 22 V -1 08/27/21, 10:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15714
-
core-ci voted on patch set 23 V +1 08/27/21, 11:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15715
-
Helmut Hummel voted on patch set 23 CR 0 08/27/21, 11:02
-
Benjamin Franzke uploaded patch set 24 08/27/21, 12:05
-
core-ci voted on patch set 24 V +1 08/27/21, 12:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15721
-
Christian Kuhn commented on patch set 24 CR -1 08/27/21, 12:24
working on it. -
Christian Kuhn commented on patch set 24 08/27/21, 12:32
composer.dist.json:56we'll use that file in a CI job to test composer update and composer update --pefer-lowest later ... that'll be a dedicated patch, though. -
Christian Kuhn uploaded patch set 25 08/27/21, 14:03
-
Christian Kuhn commented on patch set 25 CR -1 08/27/21, 14:15
helmut working on it. -
Helmut Hummel uploaded patch set 26 08/27/21, 14:16
-
core-ci voted on patch set 25 V -1 08/27/21, 14:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15728
-
Christian Kuhn commented on patch set 26 CR -1 08/27/21, 14:20
working on it. -
core-ci voted on patch set 25 V +1 08/27/21, 14:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15728
-
core-ci voted on patch set 26 V +1 08/27/21, 14:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15729
-
Helmut Hummel uploaded patch set 27 08/27/21, 14:41
-
Christian Kuhn uploaded patch set 28 08/27/21, 15:00
-
core-ci voted on patch set 27 V -1 08/27/21, 15:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15731
-
Benjamin Franzke voted on patch set 28 V +1 CR +1 08/27/21, 15:03
-
Jochen Roth voted on patch set 28 V +1 CR +1 08/27/21, 15:07
-
Christian Kuhn voted on patch set 28 V +1 CR +1 08/27/21, 15:10
-
Helmut Hummel commented on patch set 28 V +2 CR +2 08/27/21, 15:15
Thanks a bunch to everybody involved! -
core-ci voted on patch set 28 V +1 08/27/21, 15:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15733
-
Helmut Hummel merged patch set 29 08/27/21, 15:16