Review main Merged

69176[BUGFIX] Allow persisting PseudoFileReference via database form finisher

Oliver Hader CR +2 V +2 Easy +9 −0 updated 05/18/21, 19:43

Commit message

To "encapsulate" resources that were uploaded using a form element, a
new PseudoFileReference class was introduced in TYPO3-CORE-SA-2021-002,
extending Extbase's FileReference domain model.

When trying to persist those files using Extbase's PersistenceManager,
the corresponding database table is assumed to be (inferred from class)
`tx_form_mvc_property_typeconverter_pseudofilereference` instead of
correct `sys_file_reference`.

In order to solve this issue, a corresponding mapping for the new domain
model is introduced.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Oliver Hader uploaded patch set 1 05/18/21, 14:12

  2. core-ci voted on patch set 1 V +1 05/18/21, 14:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11620

  3. Oliver Hader updated the commit message in patch set 2 05/18/21, 14:28

  4. Oliver Hader updated the commit message in patch set 3 05/18/21, 14:28

  5. core-ci voted on patch set 2 V +1 05/18/21, 14:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11624

  6. core-ci voted on patch set 3 V +1 05/18/21, 14:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11625

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 05/18/21, 16:45

  8. Georg Ringer voted on patch set 3 V +2 CR +2 05/18/21, 19:43

  9. Georg Ringer merged patch set 4 05/18/21, 19:43