Review main Merged

69177[BUGFIX] Handle LEFT JOINs in Extbase correctly

Markus Klein CR +2 V +2 Easy +24 −5 updated 05/20/21, 17:28

Commit message

Since Core's query builder now uses correct outer joins
including enable field filters, Extbase can rely on this
behaviour too and therefore does not need to fiddle with
visibility constraints for related tables (e.g. MM) anymore.
Rows are filtered on the database side now already.

This fixes the behaviour for MM relations, where the related
record is disabled/hidden and hence must not be returned as
related record.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Chris Müller +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1722

  1. Markus Klein uploaded patch set 1 05/18/21, 14:18

  2. core-ci voted on patch set 1 V +1 05/18/21, 14:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11621

  3. Markus Klein uploaded patch set 2 05/18/21, 14:35

  4. Markus Klein marked it ready for review 05/18/21, 14:36

  5. Markus Klein commented on patch set 2 05/18/21, 14:38

    v9 backport needs to be merged together with https://review.typo3.org/c/Packages/TYPO3.CMS/+/68792
  6. core-ci voted on patch set 2 V -1 05/18/21, 14:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11627

  7. Markus Klein uploaded patch set 3 05/18/21, 15:12

  8. core-ci voted on patch set 3 V -1 05/18/21, 15:22 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11629

  9. Markus Klein uploaded patch set 4 05/18/21, 15:42

  10. core-ci voted on patch set 4 V +1 05/18/21, 15:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11630

  11. Chris Müller voted on patch set 4 V +1 05/18/21, 18:30

  12. Nikita Hovratov voted on patch set 4 V +1 CR +1 05/19/21, 16:53

  13. Benni Mack commented on patch set 4 05/19/21, 20:22

    categories.xml:35

    can you please keep the indention as the other lines?

    category-mm.xml:28

    same here.
  14. Markus Klein commented on patch set 4 05/19/21, 20:58

    categories.xml:35 Reply

    uh good catch. sorry, didn't see this in phpstorm, nor did I spot it here.
  15. Markus Klein uploaded patch set 5 05/19/21, 21:00

  16. Markus Klein commented on patch set 5 05/19/21, 21:00

    categories.xml:35 Reply

    Done

    category-mm.xml:28 Reply

    Done
  17. core-ci voted on patch set 5 V +1 05/19/21, 21:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11684

  18. Chris Müller voted on patch set 5 V +1 05/20/21, 05:15

  19. Nikita Hovratov voted on patch set 5 V +1 CR +1 05/20/21, 07:20

  20. Benni Mack voted on patch set 5 CR +1 05/20/21, 09:06

  21. Benni Mack voted on patch set 5 V +2 CR +2 05/20/21, 17:28

  22. Benni Mack merged patch set 6 05/20/21, 17:28