69177[BUGFIX] Handle LEFT JOINs in Extbase correctly
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Chris Müller +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/categories.xml3+9 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/category-mm.xml2+9 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+6 −3
Review log 1722
-
Markus Klein uploaded patch set 1 05/18/21, 14:18
-
core-ci voted on patch set 1 V +1 05/18/21, 14:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11621
-
Markus Klein uploaded patch set 2 05/18/21, 14:35
-
Markus Klein marked it ready for review 05/18/21, 14:36
-
Markus Klein commented on patch set 2 05/18/21, 14:38
v9 backport needs to be merged together with https://review.typo3.org/c/Packages/TYPO3.CMS/+/68792 -
core-ci voted on patch set 2 V -1 05/18/21, 14:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11627
-
Markus Klein uploaded patch set 3 05/18/21, 15:12
-
core-ci voted on patch set 3 V -1 05/18/21, 15:22 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11629
-
Markus Klein uploaded patch set 4 05/18/21, 15:42
-
core-ci voted on patch set 4 V +1 05/18/21, 15:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11630
-
Chris Müller voted on patch set 4 V +1 05/18/21, 18:30
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 05/19/21, 16:53
-
Benni Mack commented on patch set 4 05/19/21, 20:22
categories.xml:35can you please keep the indention as the other lines?category-mm.xml:28same here. -
Markus Klein commented on patch set 4 05/19/21, 20:58
categories.xml:35Replyuh good catch. sorry, didn't see this in phpstorm, nor did I spot it here. -
Markus Klein uploaded patch set 5 05/19/21, 21:00
-
Markus Klein commented on patch set 5 05/19/21, 21:00
categories.xml:35ReplyDonecategory-mm.xml:28ReplyDone -
core-ci voted on patch set 5 V +1 05/19/21, 21:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11684
-
Chris Müller voted on patch set 5 V +1 05/20/21, 05:15
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 05/20/21, 07:20
-
Benni Mack voted on patch set 5 CR +1 05/20/21, 09:06
-
Benni Mack voted on patch set 5 V +2 CR +2 05/20/21, 17:28
-
Benni Mack merged patch set 6 05/20/21, 17:28