Review main Merged

69181[BUGFIX] Re-calculate z-index of modal and its backdrop

Andreas Kienast CR +2 V +2 Easy +10 −1 updated 05/27/21, 16:40

Commit message

Bootstraps modals are not designed to have multiple instances opened at
once, which was workarounded in TYPO3 a while ago. If a modal overlays
another modal AND is smaller, its backdrop does not overlay the "lower"
modal due to hardcoded z-index values.

With this patch the z-index of both, the modal and its backdrop are
re-calculated depending on the amount of open modals. We use "1000" as
an overall base to circumvent a stuttering UI as Bootstrap uses a z-index
of "1040" for backdrops on initial rendering.
However, this will clash again when at least four modals are open, which
is fine and should never happen - if it does, it at least reveals a
bad UX.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 05/18/21, 21:25

  2. Andreas Kienast commented on patch set 1 05/18/21, 21:27

  3. core-ci voted on patch set 1 V +1 05/18/21, 21:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11646

  4. Andreas Kienast updated the commit message in patch set 2 05/18/21, 21:35

  5. core-ci voted on patch set 2 V +1 05/18/21, 21:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11650

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 05/25/21, 17:39

  7. Jochen Roth voted on patch set 2 V +1 CR +1 05/27/21, 16:40

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 05/27/21, 16:40

  9. Christian Kuhn merged patch set 3 05/27/21, 16:40