Review main Merged

69182[TASK] Improve input fields in the authentication step of MFA

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 05/19/21, 14:38

Commit message

The input fields for entering the one-time password in
the authentication views of TOTP and recovery codes
are improved by adding two new attributes:

autocomplete="one-time-code"
========================

In supporting browsers (mostly on mobile devices), this
allows them to suggest or even insert one-time passwords,
received e.g. via SMS.

See:

- https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#values
- https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element

As a side effect this might also prevent browsers from
auto completing the fields with unsuitable data, since
this feature is usually enabled by default (autocomplete
attribute not set).

See: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion

inputmode="numeric"
=================

In supporting browsers (mostly on mobile devices), this
changes the keyboard layout to numeric. This is helpful,
since only digits of 0-9 are required / allowed.

See:

- https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode
- https://css-tricks.com/everything-you-ever-wanted-to-know-about-inputmode/#numeric

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
    • Torben Hansen +1
    • Richard Haeser +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oli Bartsch uploaded patch set 1 05/19/21, 10:19

  2. Richard Haeser voted on patch set 1 CR +1 05/19/21, 10:28

  3. core-ci voted on patch set 1 V +1 05/19/21, 10:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11668

  4. Torben Hansen voted on patch set 1 CR +1 05/19/21, 11:59

  5. Jochen Roth voted on patch set 1 V +1 CR +1 05/19/21, 13:18

  6. Christian Kuhn voted on patch set 1 V +1 CR +1 05/19/21, 13:33

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 05/19/21, 14:38

  8. Benjamin Franzke merged patch set 2 05/19/21, 14:38