Review main Merged

69183[TASK] Streamline PackageManager internals

Helmut Hummel CR +2 V +2 Normal +40 −143 updated 05/25/21, 19:45

Commit message

This change removes and modifies a few places within
PackageManager code which was built before composer
files contained the extension-key information, and
before Composer Mode installations used the subtree
split packages for core (TYPO3 v8).

The change does the following:
* Removes a fallback for the "cms" package requirement
* Prefers extra.typo3/cms.extension-key of composer.json over the folder name for extension key
* Removes lowercasing Composer names, since Composer enforces this now
* Gracefully allow packages without ext_emconf.php to exist
  (will become relevant with following changes)
* Ignore composer.json requires and suggests, when ext_emconf.php exists

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1319

  1. Helmut Hummel uploaded patch set 1 05/19/21, 12:08

  2. Helmut Hummel updated the commit message in patch set 2 05/19/21, 12:10

  3. core-ci voted on patch set 1 V -1 05/19/21, 12:10 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11673

  4. core-ci voted on patch set 2 V -1 05/19/21, 12:11 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11674

  5. Helmut Hummel uploaded patch set 3 05/20/21, 10:19

  6. core-ci voted on patch set 3 V -1 05/20/21, 10:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11702

  7. Helmut Hummel uploaded patch set 4 05/20/21, 10:22

  8. core-ci voted on patch set 4 V -1 05/20/21, 10:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11703

  9. Helmut Hummel uploaded patch set 5 05/20/21, 10:34

  10. core-ci voted on patch set 5 V +1 05/20/21, 10:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11704

  11. Benjamin Franzke commented on patch set 5 CR +1 05/20/21, 12:13

    PackageManager.php:844

    Small nitpick, maybe use ?array and return null instead of an empty array when no EmConf exists? Read's slightly better in the usage in `getComposerManifest` where we can avoid !empty() then and rather use !== null. And it's clear then that ext_emconf with a content like `$EM_CONF[$_EXTKEY] = [];` is not valid/meant then… Other than that, CR+1.
  12. Benni Mack commented on patch set 5 05/20/21, 12:26

    PackageManager.php:29

    we can remove the exception class as well now.
  13. Benni Mack uploaded patch set 6 05/20/21, 17:39

  14. Benni Mack voted on patch set 6 V +1 CR +1 05/20/21, 17:39

  15. core-ci voted on patch set 6 V +1 05/20/21, 17:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11734

  16. Jochen Roth voted on patch set 6 V +1 CR +1 05/25/21, 13:34

  17. Benjamin Franzke voted on patch set 6 V +2 CR +2 05/25/21, 19:44

  18. Benjamin Franzke commented on patch set 6 05/25/21, 19:45

    PackageManager.php:29 Reply

    Done

    PackageManager.php:844 Reply

    Done
  19. Benjamin Franzke merged patch set 7 05/25/21, 19:45