Review main Merged

69184[BUGFIX] Restore FormEngine field label and description margins

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 05/19/21, 15:10

Commit message

Since #93519, the form-control-wrap class did not longer
define any margin-top. Therefore TCA field descriptions
were displayed right above the field without any space.

This is fixed by adding the margin again. Also the
labels' margin is adjusted to use the correct variable.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 05/19/21, 14:14

  2. core-ci voted on patch set 1 V +1 05/19/21, 14:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11676

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 05/19/21, 14:44

  4. Jochen Roth voted on patch set 1 V +1 CR +1 05/19/21, 14:57

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 05/19/21, 15:10

  6. Oli Bartsch merged patch set 2 05/19/21, 15:10