Review main Merged

69187[TASK] Clean up JavaScript code smells

Oliver Hader CR +2 V +2 Normal +16 −36 updated 05/26/21, 04:37

Commit message

Several JavaScript code smells are cleaned up
and duplicate/superfluous parts removed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 67

  1. Oliver Hader uploaded patch set 1 05/19/21, 21:29

  2. core-ci voted on patch set 1 V +1 05/19/21, 21:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11685

  3. Benni Mack voted on patch set 1 V +1 CR +1 05/25/21, 13:32

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 05/25/21, 14:20

  5. Christian Kuhn voted on patch set 1 CR +1 05/25/21, 14:26

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 05/26/21, 04:37

  7. Benjamin Franzke merged patch set 2 05/26/21, 04:37