Review main Merged

69188[TASK] Avoid usages of sys_language in site configuration

Oli Bartsch CR +2 V +2 Expert +1680 −249 updated 06/29/21, 12:33

Commit message

This patch removes the last remains of sys_language in the
site configurations' TCA.

Therefore, the TCA of `site` and `site_langauge` is changed
to always retrieve possible site languages via an itemsProcFunc,
instead of using a relation to sys_language.

As new site languages now have to be created in the module
directly, a new internal TCA type "siteLanguage" is introduced.
The new type behaves similar to type "inline", but contains some
necessary features, e.g. unique record selector box next to a
"create new" button, which are not available in type "inline".
Also some not needed functionality is omitted.

Instead of the sys_language records, all available site languages
from all existing site configurations are now presented in the
selector box. On selecting one of them, a new site language record
is created, with most of the fields pre filled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 3156

Show 1631 earlier messages
  1. Oli Bartsch uploaded patch set 1 05/19/21, 21:30

  2. Oli Bartsch updated the commit message in patch set 2 05/19/21, 21:38

  3. core-ci voted on patch set 1 V +1 05/19/21, 21:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11686

  4. core-ci voted on patch set 2 V +1 05/19/21, 21:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11687

  5. Oli Bartsch uploaded patch set 3 06/14/21, 09:02

  6. core-ci voted on patch set 3 V +1 06/14/21, 09:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12390

  7. Oli Bartsch uploaded patch set 4 06/15/21, 14:13

  8. core-ci voted on patch set 4 V -1 06/15/21, 14:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12450

  9. Oli Bartsch uploaded patch set 5 06/21/21, 09:24

  10. core-ci voted on patch set 5 V -1 06/21/21, 09:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12617

  11. Oli Bartsch uploaded patch set 6 06/21/21, 10:04

  12. core-ci voted on patch set 6 V -1 06/21/21, 10:18 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12622

  13. Oli Bartsch uploaded patch set 7 06/21/21, 12:45

  14. core-ci voted on patch set 7 V -1 06/21/21, 12:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12626

  15. Oli Bartsch uploaded patch set 8 06/21/21, 19:24

  16. core-ci voted on patch set 8 V -1 06/21/21, 19:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12653

  17. Oli Bartsch uploaded patch set 9 06/21/21, 21:26

  18. Oli Bartsch uploaded patch set 10 06/21/21, 21:27

  19. core-ci voted on patch set 9 V +1 06/21/21, 21:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12655

  20. core-ci voted on patch set 10 V +1 06/21/21, 21:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12656

  21. Oli Bartsch uploaded patch set 11 06/21/21, 23:09

  22. core-ci voted on patch set 11 V +1 06/21/21, 23:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12657

  23. Oli Bartsch uploaded patch set 12 06/22/21, 14:16

  24. core-ci voted on patch set 12 V -1 06/22/21, 14:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12667

  25. Oli Bartsch uploaded patch set 13 06/22/21, 14:56

  26. core-ci voted on patch set 13 V -1 06/22/21, 15:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12669

  27. Oli Bartsch uploaded patch set 14 06/22/21, 19:54

  28. core-ci voted on patch set 14 V -1 06/22/21, 20:05 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12677

  29. Oli Bartsch uploaded patch set 15 06/22/21, 20:37

  30. core-ci voted on patch set 15 V +1 06/22/21, 20:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12678

  31. Oli Bartsch uploaded patch set 16 06/22/21, 23:08

  1. core-ci voted on patch set 16 V +1 06/22/21, 23:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12680

  2. Oli Bartsch uploaded patch set 17 06/22/21, 23:28

  3. core-ci voted on patch set 17 V +1 06/22/21, 23:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12681

  4. Oli Bartsch uploaded patch set 18 06/23/21, 11:19

  5. core-ci voted on patch set 18 V +1 06/23/21, 11:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12689

  6. Oli Bartsch uploaded patch set 19 06/23/21, 12:41

  7. core-ci voted on patch set 19 V +1 06/23/21, 12:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12690

  8. Oli Bartsch uploaded patch set 20 06/23/21, 13:15

  9. core-ci voted on patch set 20 V +1 06/23/21, 13:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12691

  10. Oli Bartsch uploaded patch set 21 06/24/21, 12:08

  11. core-ci voted on patch set 21 V +1 06/24/21, 12:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12707

  12. Oli Bartsch uploaded patch set 22 06/24/21, 13:23

  13. core-ci voted on patch set 22 V +1 06/24/21, 13:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12708

  14. Georg Ringer updated the commit message in patch set 23 06/24/21, 18:33

  15. core-ci voted on patch set 23 V +1 06/24/21, 20:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12720

  16. Benni Mack uploaded patch set 24 06/25/21, 07:33

  17. core-ci voted on patch set 24 V +1 06/25/21, 07:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12728

  18. Oli Bartsch uploaded patch set 25 06/25/21, 09:31

  19. core-ci voted on patch set 25 V +1 06/25/21, 09:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12729

  20. Benni Mack voted on patch set 25 V +1 06/29/21, 09:41

  21. Christian Kuhn commented on patch set 25 CR -1 06/29/21, 11:44

    on it.
  22. Christian Kuhn voted on patch set 25 CR +1 06/29/21, 12:19

  23. Christian Kuhn voted on patch set 25 V +1 06/29/21, 12:22

  24. Benni Mack voted on patch set 25 V +2 CR +2 06/29/21, 12:33

  25. Benni Mack merged patch set 26 06/29/21, 12:33