Review main Merged

69191[BUGFIX] Allow editing and copying of composer proposal

Oli Bartsch CR +2 V +2 Easy +0 −1 updated 05/25/21, 17:56

Commit message

The composer manifest proposal, introduced in #93931,
uses t3editor to display the composer.json content.
The corresponding TCA was configured to be "readOnly",
which however had no effect until #94081.

Since there is no reason to disallow editing or
copying of the proposal, the "readOnly" option
is removed from the TCA configuration.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Oli Bartsch uploaded patch set 1 05/20/21, 08:47

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 05/20/21, 08:49

  3. core-ci voted on patch set 1 V +1 05/20/21, 08:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11697

  4. Jochen Roth voted on patch set 1 V +1 CR +1 05/20/21, 09:05

  5. Oli Bartsch updated the commit message in patch set 2 05/20/21, 10:12

  6. core-ci voted on patch set 2 V +1 05/20/21, 10:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11701

  7. Christian Kuhn updated the commit message in patch set 3 05/20/21, 10:56

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 05/20/21, 10:56

  9. core-ci voted on patch set 3 V +1 05/20/21, 11:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11705

  10. Jochen Roth voted on patch set 3 V +1 CR +1 05/20/21, 11:21

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 05/20/21, 11:25

  12. Oli Bartsch merged patch set 4 05/20/21, 11:25

  13. Oli Bartsch commented on patch set 4 05/25/21, 17:56

    The Resolves line is wrong. Must be #94168. #93931 is only a relation.