Review 10.4 Merged

69196[TASK] Simplify trimExplode()

Christian Kuhn CR +2 V +2 Easy +26 −17 updated 05/20/21, 16:18

Commit message

Make the code a bit more declarative and compact.
This also improves the documentation to make clear
the actual behavior, which was previously not self-evident.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Christian Kuhn commented on patch set 1 05/20/21, 15:27

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V -1 05/20/21, 15:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11724

  3. Christian Kuhn uploaded patch set 2 05/20/21, 15:44

  4. core-ci voted on patch set 2 V +1 05/20/21, 15:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11725

  5. Christian Kuhn voted on patch set 2 V +2 CR +2 05/20/21, 16:18

  6. Christian Kuhn merged patch set 3 05/20/21, 16:18