Review main Merged

69212[BUGFIX] Allow copying content from readonly t3editor field

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 05/20/21, 10:13

Commit message

With #94081, a new option was introduced to
set a FormEngine t3editor field to "readOnly",
as it was already possible for default text fields.

Using the option "nocursor" however also disabled
copying of the content, which is not intended and
also not in line with the behaviour of "readOnly" for
normal text elements.

Therefore, when "readOnly" is set in TCA for renderType
t3editor, the codeMirror related option is set to TRUE,
which still renders the field as readOnly, but allows to
copy its content again.

For further reference see:

https://codemirror.net/doc/manual.html#option_readOnly

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 05/20/21, 09:09

  2. Oli Bartsch updated the commit message in patch set 2 05/20/21, 09:14

  3. core-ci voted on patch set 1 V +1 05/20/21, 09:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11699

  4. core-ci voted on patch set 2 V +1 05/20/21, 09:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11700

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 05/20/21, 09:53

  6. Jochen Roth voted on patch set 2 V +1 CR +1 05/20/21, 10:00

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 05/20/21, 10:13

  8. Oli Bartsch merged patch set 3 05/20/21, 10:13