Review main Merged

69214[BUGFIX] Use native "recordTitle" for FormEngine title

Benni Mack CR +2 V +2 Normal +1 −116 updated 05/20/21, 14:32

Commit message

The PHP8 incompatible FormEngineUtility::databaseRowCompatibility()
is not needed since TYPO3 v7 LTS, as the TcaRecordTitle
provider has the information stored already.

The usage $this->storeTitle is probably not needed anymore
and can be removed later-on.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Benni Mack uploaded patch set 1 05/20/21, 13:39

  2. core-ci voted on patch set 1 V +1 05/20/21, 13:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11712

  3. Markus Klein updated the commit message in patch set 2 05/20/21, 13:58

  4. Markus Klein voted on patch set 2 V +1 CR +1 05/20/21, 13:58

  5. Christian Kuhn commented on patch set 2 CR -1 05/20/21, 14:02

    lemme check some details ;>)
  6. core-ci voted on patch set 2 V +1 05/20/21, 14:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11714

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 05/20/21, 14:31

  8. Benni Mack voted on patch set 2 V +2 CR +2 05/20/21, 14:32

  9. Benni Mack merged patch set 3 05/20/21, 14:32