Review main Merged

69215[BUGFIX] Check request object in ExtensionComposerStatus

Jochen Roth CR +2 V +2 Easy +14 −13 updated 05/20/21, 14:59

Commit message

Although the ExtensionComposerStatus report implements the
RequestAwareStatusProviderInterface, there is no guarantee
that a PSR-7 request is passed to getStatus().

To prevent type errors we have to ensure, the request
object is set, before accessing its values.

This patch therefore checks the request object before
adding the returnUrl argument to the query parameters.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • André Buchmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • André Buchmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Jochen Roth uploaded patch set 1 05/20/21, 13:59

  2. Oli Bartsch updated the commit message in patch set 2 05/20/21, 14:08

  3. André Buchmann commented on patch set 2 V +1 CR +1 05/20/21, 14:11

    Thx for quick fix. Works fine!
  4. Oli Bartsch voted on patch set 2 V +1 CR +1 05/20/21, 14:12

  5. core-ci voted on patch set 1 V +1 05/20/21, 14:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11715

  6. core-ci voted on patch set 2 V +1 05/20/21, 14:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11716

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 05/20/21, 14:59

  8. Christian Kuhn merged patch set 3 05/20/21, 14:59