Review main Merged

69216[BUGFIX] Avoid PHP TypeError in EXT:lowlevel

Benni Mack CR +2 V +2 Easy +0 −3 updated 05/20/21, 17:42

Commit message

EXT:lowlevel gathers some statistics, e.g. deleted
records in general. However, by looking at the code,
recStats[deleted] is grouped by TCA types, but 4 lines
later it is treated as a numeric integer.

This never worked, and actually throws a notice (and in PHP8 a
TypeError).

This code can be removed, as it never worked properly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 05/20/21, 16:38

  2. Oli Bartsch voted on patch set 1 CR +1 05/20/21, 16:48

  3. core-ci voted on patch set 1 V +1 05/20/21, 16:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11727

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 05/20/21, 16:58

  5. Jochen Roth voted on patch set 1 V +1 CR +1 05/20/21, 17:42

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 05/20/21, 17:42

  7. Christian Kuhn merged patch set 2 05/20/21, 17:42