Review main Merged

69218[BUGFIX] Remove legacy foreign_selector conversion

Benni Mack CR +2 V +2 Easy +0 −23 updated 05/20/21, 17:27

Commit message

During TYPO3 v7 the FormEngine got rewritten, and a "todo"
was left, which can be removed as it now contains wrong
information as this information has been processed already
in a prior FormEngine DataProvider.

It is removed because the array implode implodes a
array of arrays building $record[$foreign_selector] (e.g. FAL)
into $record[$foreign_selector] = 'Array'; which was never
used within the InlineReordContainer anymore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 05/20/21, 16:42

  2. Christian Kuhn commented on patch set 1 V +1 CR +1 05/20/21, 16:45

    Debugged this together with Benni ... we're confident this is ok ^^
  3. core-ci voted on patch set 1 V +1 05/20/21, 16:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11729

  4. Jochen Roth voted on patch set 1 V +1 CR +1 05/20/21, 17:26

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 05/20/21, 17:26

  6. Christian Kuhn merged patch set 2 05/20/21, 17:27